Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Warehouse save() #5

Open
totalhack opened this issue Mar 20, 2023 · 0 comments
Open

Improve Warehouse save() #5

totalhack opened this issue Mar 20, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@totalhack
Copy link
Owner

Currently a Warehouse can only be safely saved if it was created with reference to a config file and the Warehouse config was not changed in memory after init (if so it would be out of sync with the referenced file). This works OK in use cases where a config file is the master structure of the Warehouse and you aren't editing a Warehouse in memory, but it would be better if the Warehouse could reconstruct and save the current active config back to a specified file path in save() even if it wasn't created from a config file/url.

One caveat is if the Warehouse was created from a remote config file there may be no way to post changes back, so it would only be able to save a local file config without additional changes to try to support pushing warehouse changes to other locations (remote files, git, s3, etc).

One way or another this process should be cleaned up. Either the door needs to be closed on in-memory editing of a Warehouse config (a file is the only possible master and all changes go through that) or we need to support reconstructing and saving a config from the current Warehouse settings.

@totalhack totalhack added the enhancement New feature or request label Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant