Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double x-default link tag on home page #773

Open
nicolas-cusan opened this issue Jan 20, 2023 · 1 comment
Open

Double x-default link tag on home page #773

nicolas-cusan opened this issue Jan 20, 2023 · 1 comment

Comments

@nicolas-cusan
Copy link

nicolas-cusan commented Jan 20, 2023 •
edited

Hello! Thank you for the great library.

I am working on a project using:

{
  "silverstripe/recipe-cms": "~4.12.0@stable",
  "tractorcow/silverstripe-fluent": "5.1.1",
}

And have two locales en_US and es_ES, English being the default locale.

On the home page inside my <head> tag there are two <link hreflang="x-default"> tags being rendered, both for English:

<link rel="alternate" hreflang="x-default" href="https://example.com/" />
<link rel="alternate" hreflang="x-default" href="https://example.com/en/" />
<link rel="alternate" hreflang="es-es" href="https://example.com/es/" />

Now my question is, is this correct or is this a bug? If correct is there any documentation to support this, I could not find anything online.

I noticed this while testing with an online testing tool that was throwing an error on the home page (TBH the tool looks kind of old so don't know it is reliable: https://app.hreflang.org/)

Any feedback is much appreciated!
@tractorcow
Copy link
Collaborator

That does seem to be a bug, yes.

@nicolas-cusan nicolas-cusan changed the title [Question] - Double x-default on home page Double x-default link tag on home page Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tractorcow @nicolas-cusan