Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to control "Too many messages like this! I won't log this message anymore this session." #6731

Open
animetosho opened this issue Mar 24, 2024 · 2 comments
Labels
good first issue For people who'd like to start contributing type:feat A new feature

Comments

@animetosho
Copy link

What is the issue?

It seems like there's a hard coded limit of 30 log messages before logging gets suppressed.
It may be useful if there's an option to control this limit and/or remove it entirely. (the point of a log, after all, is to have a record of all issues that arise)

Thanks!

Which application of Transmission?

transmission-daemon

Which version of Transmission?

4.*

@killemov
Copy link

Sometimes I experience some spurious logging with the exact same line. (Problems with tracker X.) That could be suppressed IMHO.

@nevack
Copy link
Member

nevack commented Mar 24, 2024

@ckerr If you are ok with the idea, this is pretty much straightforward thing to do and may be labeled with "good first issue".

Notes for anyone wanting to implement this:

  1. Add some new uint64_t/size_t pref with name like "log message max repeat".
  2. Setting this pref to 0 means no limit at all.
  3. Default compiled-in value must be zero, to disable MaxRepeat with cli tools like create, show, etc.
  4. Default value for daemon is debatable, some pretty low limit like 30 is ok, but daemon at least allows you to override compiled in value with settings.json.
  5. Default value for clients is debatable, but also should be overridable with settings.json.

@ckerr ckerr added good first issue For people who'd like to start contributing type:feat A new feature labels Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue For people who'd like to start contributing type:feat A new feature
Development

No branches or pull requests

4 participants