Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add typehints #11

Open
jf--- opened this issue Mar 23, 2021 · 5 comments
Open

add typehints #11

jf--- opened this issue Mar 23, 2021 · 5 comments

Comments

@jf---
Copy link

jf--- commented Mar 23, 2021

as it says on the tin -- I think typehints would be a welcome addition.
@trelau would you accept such a PR, since that would basically make the project python>=3.6+?

@trelau
Copy link
Owner

trelau commented Mar 24, 2021

Yes, I think so. AFEM depends on pyOCCT which is only supported for 3.6 and above.

As a side note, I've been trying to migrate pyOCCT and pySMESH to latest versions (OCCT 7.5.0 and SMESH 9.6.0) but hit a snag here trelau/SMESH#37. Note I also broke out pySMESH from pyOCCT.

@jf---
Copy link
Author

jf--- commented Mar 25, 2021

Great to see the 7.5 update is nearby... The smesh breakout is a solid idea...
Great, I'll horse around wrt type hints...

I understand that the issue wrt SMESH is mostly osx related?

@trelau
Copy link
Owner

trelau commented Mar 26, 2021

Yes it seems osx related and so far has me stumped (and i don't have a local osx system to quickly debug...)

@jf---
Copy link
Author

jf--- commented Mar 26, 2021

Understood. Is this keeping you from releasing the breakout version of (pay)smesh & pyocct (occt 7.5)?

@trelau
Copy link
Owner

trelau commented Mar 26, 2021

Yes. I’d like to get pyocct, smesh, and pysmesh fully updated to latest versions of OCCT (7.5) and Salome (9.6) and update the conda feedstock for SMESH. Then refresh afem with new libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants