Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating existing installation results in errors using Win-64 installer #1069

Closed
panther2 opened this issue Aug 15, 2016 · 25 comments
Closed
Labels
Problem A problem, bug, defect - something to fix
Milestone

Comments

@panther2
Copy link
Contributor

panther2 commented Aug 15, 2016

I tested and reproduced the issue with different prerelease versions.
Steps to reproduce:

  • Have an older version installed, for example 2749
  • Install a newer version (I used 2756) choosing "Yes, update the existing installation"
  • Installer shows "Uninstalling previous version"
  • Installer installs new version. So far so good.

When executing triplea.exe, a window pops up saying "Couldn't load main class"

When uninstalling through the control panel, a window pops up saying: "Error, maybe it has been uninstalled before, do you want to remove the entry from the list?"

In some cases there has not even been an entry in the programs' list in the control panel.

The folder of the TripleA installation has to be manually deleted.

When installing "new" (without updating) everything runs fine again.

I also noticed that - when updating an existing installation - the file "uninstall.exe" is not present in the triplea directory.

@ron-murhammer ron-murhammer added the Problem A problem, bug, defect - something to fix label Aug 16, 2016
@ron-murhammer ron-murhammer added this to the 1.9 milestone Aug 16, 2016
@DanVanAtta
Copy link
Member

@RoiEXLab @ron-murhammer @gaborbernat , could one of you look into this? running linux here, wont' be able to do this as efficiently with a VM

@panther2 which version of windows?

@panther2
Copy link
Contributor Author

Up-to-date Windows 7, 64 bit. Java 8u101.

@DanVanAtta
Copy link
Member

The installer was tweaked, @panther2 - could you give it another shot?

@panther2
Copy link
Contributor Author

panther2 commented Aug 18, 2016

@DanVanAtta

Tried all new versions up to and including 2817.
Same issues as before, sorry.

@DanVanAtta
Copy link
Member

Could you give 2823 a try?

@panther2
Copy link
Contributor Author

panther2 commented Aug 19, 2016

@DanVanAtta

I tested 2829 - no success again. Same issues still, sorry.

@prastle
Copy link
Contributor

prastle commented Aug 19, 2016

Just dl the new from both i.o and direct x64
can confirm above written by panther
( Am Sad other version was working ) but I erased that installer and forget which one it was

@DanVanAtta
Copy link
Member

not good to hear. There have not really been any updates to the installer. If anyone is able to pinpoint any of the last working versions, or even when it broke, would be tremendously valuable. Not running windows, I have trouble working on this..

@prastle
Copy link
Contributor

prastle commented Aug 20, 2016

rough guess two weeks ago was last one I installed that worked
shouldn't have overwrote it

@DanVanAtta
Copy link
Member

DanVanAtta commented Aug 20, 2016

Had some luck on a VM, hopefully will work for win7.

Please first uninstall any existing 1.9 installations.
Then install: 1.9.0.0.2836
Then please try to upgrade to: 1.9.0.0.2840, this will simulate future updates to the game.

Fingers crossed.. Not much else left that has to be done before we release

@DanVanAtta
Copy link
Member

Still seeing problem. Though, game can be launched via command line. The .exe file is not functional though ...

@prastle
Copy link
Contributor

prastle commented Aug 20, 2016

I'm win 10
ill try when ur ready

@panther2
Copy link
Contributor Author

Yes, i must confirm that the same issues still occur trying 2836/2840.

I wonder that the file "uninstall.exe" is not copied to the directory when updating...
Maybe there are some activities of the older installation present "in the background" that prevent the correct installation and execution of the new files (just an amateurish idea of course)?

@prastle
Copy link
Contributor

prastle commented Aug 20, 2016

I also manually deleted whole file. And complete new install. It No longer asked to uninstall. Still same error.

@RoiEXLab
Copy link
Member

RoiEXLab commented Aug 20, 2016

Could somebody test this with versions 1.9.0.0.2603 and prior? Not sure wether this solves this problem, but this is my only idea.
Releases

@panther2
Copy link
Contributor Author

I installed 2603 over 2599 - still the same issues.

@RoiEXLab
Copy link
Member

Ok that means, that the problem is not occuring due to the GameRunner change.

@panther2
Copy link
Contributor Author

I have no idea for how long this issue exists. I noticed it by accident. Because regularly I perform a clean uninstall before installing a new version.

@panther2
Copy link
Contributor Author

The oldest versions I have tested by now are 2572 over 2565 - same issues - so it must have been introduced even before.

@DanVanAtta
Copy link
Member

DanVanAtta commented Aug 20, 2016

I somewhat suspect that maybe it was always a problem.

I've been looking at ways to disable the 'replace existing install' and force a new install into a new folder. Has not been fruitful yet, and also updating the overwrite modes to always overwriting. Bit of a slow process..

thanks for the help in checking versions.

@DanVanAtta
Copy link
Member

Okay, found a way to work around this problem to some benefit. I've updated the installer so that it no longer prompts to install over the last version. Now the game is installed to a new versioned folder each time. This will allow you to run multiple game engine versions pretty easily.

@prastle
Copy link
Contributor

prastle commented Aug 22, 2016

Great ty I will give it a shot

@panther2
Copy link
Contributor Author

Fair workaround! That leaves the user the option to either perform an uninstall before in order to install the new version into the same directory or use different versions in different directories.
I am closing this issue now. Thanks!

@prastle
Copy link
Contributor

prastle commented Aug 22, 2016

Sadly I am still getting the white screen java error. What was the fix for this?

@panther2
Copy link
Contributor Author

@prastle
Look here: #1090

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Problem A problem, bug, defect - something to fix
Projects
None yet
Development

No branches or pull requests

5 participants