Thunderbird 68 support #30

tasn · 2019-09-11T11:34:13Z

Please add support for Thunderbird 68. I can't use thunderbird without this extension!!! :)

Thanks!

jikamens · 2019-09-11T11:45:16Z

I tried and failed a few months ago. :-)

It's not impossible, it's just that I didn't have the knowledge and experience necessary to accomplish it at the time and didn't have time to learn it.

I'm hoping someone else will step up to help, but so far no one has.

In the meantime, you can use my userChromeJS add-on to run JavaScript which modifies key bindings, though that's obviously not as user-friendly as keyconfig.

Here's some sample code from my own userChrome.js file:

function userChromeUnbindKey(keyset_id, key_id) {
    var keyset = document.getElementById(keyset_id);
    if (! keyset) {
        console.log("Could not find keyset " + keyset_id);
        return;
    }
    var key = document.getElementById(key_id);
    if (! key) {
        console.log("Could not find key " + key_id);
        return;
    }
    keyset.removeChild(key);
}

function userChromeBindKey(keyset_id, key, key_id, modifiers, command, observes) {
    var keyset = document.getElementById(keyset_id);
    if (! keyset) {
        console.log("Could not find keyset " + keyset_id);
        return;
    }
    var elt = document.createXULElement("key");
    if (key)
        elt.setAttribute("key", key);
    if (key_id)
        elt.setAttribute("key_id", key);
    if (modifiers)
        elt.setAttribute("modifiers", modifiers);
    if (command)
        elt.setAttribute("oncommand", command);
    if (observes)
        elt.setAttribute("observes", observes);
    keyset.appendChild(elt);
}

I use this, e.g., to bind Alt-S in the main Thunderbird window to a custom function I wrote:

if (location == "chrome://messenger/content/messenger.xul")
    userChromeBindKey("mailKeys", "s", "key_to_spamcop", "alt",
                      "jikMoveSpam();");

tasn · 2019-09-11T15:43:00Z

Ah, thanks! I'll try to play with it and see if I can manage. :)

wshanks · 2019-09-11T19:50:31Z

I came here to ask if there were plans to port keyconfig to Thunderbird 68 as well. I tried a bit to get keyconfig working in Thunderbird 68 myself but got stuck trying to get keyconfig-service.js to load.

I decided it was quicker to start over from scratch and build back up, testing that each part worked rather than try to reverse engineer which parts of keyconfig no longer worked and what had to change to make them work again. The addon I ended up with is https://github.com/willsALMANJ/tbkeys. It has my preferred bindings hard-coded into it and does not provide for customization, but others could take it and edit in their own bindings.

If no one figures out how to port keyconfig to Thunderbird 68, I could add a UI like keyconfig's for assigning keys to javascript snippets to my extension, so it could be used more easily by others, but for now I will wait to see anyone is able to get keyconfig itself working.

tasn · 2019-09-11T20:23:28Z

@willsALMANJ, thanks a lot, I also want it for the same keybindings (vim-like).

How do I build the extension? I couldn't find any resources online. Thanks!

Edit: and I tried just zipping the add-on folder, but while it installed, it didn't work.

wshanks · 2019-09-12T04:13:54Z

@tasn Zip everything inside the addon folder (i.e. there should be no addon/ folder inside the zip archive; manifest.json, etc. should be the top level) and save it as a file ending in .xpi. Then use "Install Add-on from File.." in the Add-ons Manager.

tasn · 2019-09-12T07:44:06Z

That's exactly what I did, it doesn't work. It correctly installs the addon, but doesn't actually bind the keys.
However, if I go to "Debug addons -> temporary install" and install by choosing the manifest file, it works (though only until I restart thunderbird). Weird.

tasn · 2019-09-12T14:07:44Z

@willsALMANJ: your plugin has an issue: hitting "r" and etc in the search box also triggers the keybindings. Do you get that as well, or is something completely crazy here?

wshanks · 2019-09-12T15:29:19Z

@tasn We should move discussion of the plugin to an issue in its repo, so this issue can stay dedicated to Thunderbird 68 support for keyconfig. I created an issue for the behavior you described.

morat523035 · 2019-09-23T13:41:14Z

Here is a Dorando keyconfig version that supposedly works with Firefox 68.

http://forums.mozillazine.org/viewtopic.php?p=14845317#p14845317

wshanks · 2019-10-12T04:30:41Z

Something to be aware of: Thunderbird is dropping support of traditional add-ons completely with the next release. So trying to get something working beyond the userChrome.js workaround or the little extension I made might not be worth the effort.

tasn · 2019-10-12T09:30:44Z

:(

Your little extension will continue working though?

wshanks · 2019-10-15T18:32:38Z

No, my extension is a legacy extension as well. We need to look into what the Thunderbird developers are willing to add to MailExtensions for a keyboard shortcut API.

ftoledo · 2019-10-18T16:48:07Z

i really miss this addon on thunderbird =((

tasn · 2019-10-19T07:42:45Z

I tried not using it for a few days, and it was hell. @willsALMANJ saved the day, but apparently only temporarily. :(

I won't just miss it. I need it!

ftoledo · 2019-10-21T03:14:00Z

yeah @tasn thw @willsALMANJ extension work for me.. I just need only three shorcuts that save my life ([R]reply [A] Reply to all and [F]forward

=)
i hope that dorando-keyconfig can be ported to TB 68+

Saludos!

rubo77 · 2019-11-11T12:39:58Z

Could you please explain again for a n00b, how to make the addon work in Thunderbird 68?

ftoledo · 2019-11-11T13:31:53Z

Could you please explain again for a n00b, how to make the addon work in Thunderbird 68?

You must download or clone the source code , the put in into the extension directory at you profile

rubo77 · 2019-11-11T14:14:23Z

I tried cloning this repo, and used tar:

git clone https://github.com/trlkly/dorando-keyconfig
cd dorando-keyconfig/
tar cvzf ../dorando-keyconfig.xpi *

then install this addon as file in thunderbird 68.1.2

but still blocked there: "... not compatible"

ftoledo · 2019-11-11T14:34:56Z

hi @rubo77
You must zip the "addon" directory, not from the root directory of your clone
Saludos!

rubo77 · 2019-11-11T16:09:15Z

@tasn Zip everything inside the addon folder (i.e. there should be no addon/ folder inside the zip archive; manifest.json, etc. should be the top level) and save it as a file ending in .xpi. Then use "Install Add-on from File.." in the Add-ons Manager.

thats what I did

rubo77 · 2019-11-11T16:14:57Z

can someone please create such a working xpi archive and link it here?

wshanks · 2019-11-13T04:29:08Z

@rubo77 As far as I know, no one has gotten this add-on to work in Thunderbird 68. There was a link above about a version that worked in Firefox 68, but it wasn't clear that that really worked. There are workarounds like the userchromJS and tbkeys options linked to above. To get keyconfig to work in Thunderbird 68 would take more development time to debug which parts of the XUL API had been broken and find workarounds (without much documentation since XUL has been deprecated by Mozilla). Also, there is not much payoff to putting time into that debugging -- Thunderbird has announced that support for XUL addons like keyconfig will not be supported in the next release.

rossmeissl · 2020-01-21T15:35:49Z

For folks trying to use @jikamens userChromeJS stopgap to unbind default shortcuts (say, to free them up for the venerable Archive This), you may be wondering where to find key_id.

Find the name of the command here. You may find it easiest to search for "p", for example, to find what's currently assigned to the p key on your keyboard. In this example, you'll find:
```
<!ENTITY prevUnreadMsgCmd.key "p">
```
In this case, the name of the command is prevUnreadMsgCmd.
Now find that command here and take note of its id. For example:
```
<key id="key_previousUnreadMsg" key="&prevUnreadMsgCmd.key;"       oncommand="goDoCommand('cmd_previousUnreadMsg')"/>
```
This yields key_previousUnreadMsg which is the key_id we need for the userChromeUnbindKey function.

ftoledo · 2020-01-24T14:45:04Z

any update for the 68+ support?
i really miss this extension =( using ctrl+L to forward emails sucks! jjaja!

romanho · 2020-01-24T15:38:46Z

For the unbinding issue @rossmeissl mentioned above: I had the same issue for the 'r' key which I wanted to rebind. I did it by:

function RemoveBindings(kset, key) {
	var keyset = document.getElementById(kset);
	if (!keyset) {
		console.log("Could not find keyset " + keyset_id);
		return;
	}
	for (var e of keyset.children) {
		var k = e.getAttribute("key");
		if (k == key) {
			console.log("Remove binding "+e.id+" for key "+k);
			keyset.removeChild(e);
		}
	}
}

in my userChrome.js, and then RemoveBindings("mailKeys", "r") before binding 'r' with various modifiers. This simply removes all existing bindings.

fefabfee · 2020-01-26T14:21:51Z

I'm just an ordinary user, so my apologies if my comments on this forum are out of line. I have a simple observation. The growing pains Thunderbird is going through right now seem to be similar to what Firefox went through not long ago. I'm guessing the code might be similar. There is a developer on the Firefox side that has a shortcut add-on (https://github.com/mikecrittenden/shortkeys) that works in current version of Firefox. If the code was indeed similar, I was wondering if he could be of some help.

koolx · 2020-03-08T20:38:04Z

I'm thinking about updating TB to the latest version. I just want to change 2 keys: R for reply and N for new mail compose. How do I make that happen in the userChromeJS add-on?

wshanks · 2020-03-09T03:51:01Z

@fefabfee Unfortunately, Firefox add-ons do not translate to Thunderbird very well right now. One problem is that Firefox add-ons add a lot their user facing components (like key event listeners) through content scripts that get loaded into the current web page. This works well because in Firefox the web page is almost the entire UI. In Thunderbird, most of the UI is various elements controlled by Thunderbird. I see on Thunderbird's roadmap one item is to replace current UI with a web-based UI. Perhaps when that is done add-ons will be able to inject content scripts into the main UI that can interact with the whole UI.

sespadam · 2020-05-04T14:07:01Z

For the unbinding issue @rossmeissl mentioned above: I had the same issue for the 'r' key which I wanted to rebind. I did it by:
function RemoveBindings(kset, key) {
	var keyset = document.getElementById(kset);
	if (!keyset) {
		console.log("Could not find keyset " + keyset_id);
		return;
	}
	for (var e of keyset.children) {
		var k = e.getAttribute("key");
		if (k == key) {
			console.log("Remove binding "+e.id+" for key "+k);
			keyset.removeChild(e);
		}
	}
}
in my userChrome.js, and then RemoveBindings("mailKeys", "r") before binding 'r' with various modifiers. This simply removes all existing bindings.

Just so great! Been finally able to disable some key bidings which are quite bothering for me; at least till version 78.

michele-bs · 2020-07-16T10:24:58Z

Plaease bring keyconfig back to life!
Thunderbird 68 users are awaiting with confidence.

10,000$ for brave programmers.

ftoledo · 2020-07-16T16:35:43Z

tbkeys works, do you tried ? https://github.com/willsALMANJ/tbkeys

rubo77 · 2020-07-19T06:19:16Z

@ftoledo Thousand thanks!!! 🥇

tbkeys works!!!!

👍 👍 👍 👍 👍 👍 👍 👍 👍

I added instructions how do remap the dangerous shortcuts here:

wshanks/tbkeys#15

navennn · 2020-07-19T06:47:13Z

Thats great!
btw.
disable all shortcuts

{
    "0": "window.goDoCommand('')",
    "1": "window.goDoCommand('')",
    "2": "window.goDoCommand('')",
    "3": "window.goDoCommand('')",
    "4": "window.goDoCommand('')",
    "5": "window.goDoCommand('')",
    "6": "window.goDoCommand('')",
    "7": "window.goDoCommand('')",
    "8": "window.goDoCommand('')",
    "9": "window.goDoCommand('')",
    "a": "window.goDoCommand('')",
    "b": "window.goDoCommand('')",
    "c": "window.goDoCommand('')",
    "f": "window.goDoCommand('')",
    "j": "window.goDoCommand('')",
    "k": "window.goDoCommand('')",
    "m": "window.goDoCommand('')",
    "o": "window.goDoCommand('')",
    "p": "window.goDoCommand('')",
    "r": "window.goDoCommand('')",
    "s": "window.goDoCommand('')",
    "t": "window.goDoCommand('')",
    "u": "window.goDoCommand('')",
    "w": "window.goDoCommand('')",
    "x": "window.goDoCommand('')",
    "#": "window.goDoCommand('')",
    "]": "window.goDoCommand('')",
    "[": "window.goDoCommand('')"


}

michele-bs · 2020-07-19T06:48:39Z

Thank you all guys.

You can also refer to my related thread on Mozillazine.

koolx · 2020-07-20T03:25:28Z

hey appreicate the link.. looking into it

karmaking · 2020-09-21T20:50:32Z

FWIW:
My keyconfig killerfeature is/was pressing a single key to move a message into a specific folder, and I was able to substitute this feature with the extension "Archive this" which offers this functionality (with presets and assignable hotkeys) quite well.

Would love to switch back to dorando-keyconfig nevertheless, though! :)

eengstrom · 2020-12-04T17:32:46Z

@karmaking - you might like Nostalgy++. There was a previous version of "Nostalgy" that stopped working well prior to TB 68, but the "++" version is updated for TB 78.

karmaking · 2020-12-04T21:15:50Z

Hi @eengstrom - thanks a lot! I'm giving this a try, as "Archive this" also stopped working since TB 78...

This was referenced Jan 8, 2020

Add 'd' delete message wshanks/tbkeys#4

Closed

Add installation instructions wshanks/tbkeys#5

Closed

rossmeissl mentioned this issue Jan 21, 2020

How to unbind default keys so Archive This can use them adamroach/tb-archive-this#5

Open

Thunderbird 68 support #30

Thunderbird 68 support #30

Comments

tasn commented Sep 11, 2019

jikamens commented Sep 11, 2019 • edited

tasn commented Sep 11, 2019

wshanks commented Sep 11, 2019 • edited

tasn commented Sep 11, 2019 • edited

wshanks commented Sep 12, 2019

tasn commented Sep 12, 2019

tasn commented Sep 12, 2019

wshanks commented Sep 12, 2019

morat523035 commented Sep 23, 2019

wshanks commented Oct 12, 2019

tasn commented Oct 12, 2019

wshanks commented Oct 15, 2019

ftoledo commented Oct 18, 2019

tasn commented Oct 19, 2019

ftoledo commented Oct 21, 2019

rubo77 commented Nov 11, 2019

ftoledo commented Nov 11, 2019

rubo77 commented Nov 11, 2019

ftoledo commented Nov 11, 2019

rubo77 commented Nov 11, 2019

rubo77 commented Nov 11, 2019

wshanks commented Nov 13, 2019

rossmeissl commented Jan 21, 2020

ftoledo commented Jan 24, 2020

romanho commented Jan 24, 2020

fefabfee commented Jan 26, 2020

koolx commented Mar 8, 2020 • edited

wshanks commented Mar 9, 2020

sespadam commented May 4, 2020

michele-bs commented Jul 16, 2020

ftoledo commented Jul 16, 2020

rubo77 commented Jul 19, 2020

navennn commented Jul 19, 2020 • edited

michele-bs commented Jul 19, 2020

koolx commented Jul 20, 2020

karmaking commented Sep 21, 2020

eengstrom commented Dec 4, 2020

karmaking commented Dec 4, 2020

jikamens commented Sep 11, 2019 •

edited

wshanks commented Sep 11, 2019 •

edited

tasn commented Sep 11, 2019 •

edited

koolx commented Mar 8, 2020 •

edited

navennn commented Jul 19, 2020 •

edited