Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZFS_IOC_SEND_PROGRESS requires the name of the snapshot currently being transferred #196

Open
asomers opened this issue Jul 14, 2022 · 0 comments

Comments

@asomers
Copy link
Contributor

asomers commented Jul 14, 2022

The ZFS_IOC_SEND_PROGRESS ioctl requires the name of the snapshot currently being transferred. py-libzfs actually passes the name of the snapshot that was used to initiate the transfer. That works when sending a single snapshot, but fails when sending multiple snapshots (such as with zfs send's -I, -i, and -R options).
I have a patch for this. However, it still doesn't work to answer the question "how far along is this send that includes multiple snapshots?" because the calculated progress can exceed 100%. I think that's a limitation in libzfs, not py-libzfs. I've since abandoned ZFS_IOC_SEND_PROGRESS entirely so I'm not going to work on that patch anymore. Let me know if you would be interested in the partial solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant