fix(Menu) incorrect variable broke menu branch delete. fixes #355

tsolucio · Jan 23, 2017 · b2d7522 · b2d7522
1 parent ef09f13
commit b2d7522
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/modules/evvtMenu/Save.php b/modules/evvtMenu/Save.php
@@ -19,13 +19,14 @@
 
 function delMenuBranch($topofbranch) {
 	global $adb;
-	$mnurs = $adb->query('select evvtmenuid,mtype from vtiger_evvtmenu where mparent='.$topbranch);
-	if ($mnurs and $adb->num_rows($mnurs)>0)
-	while ($mnu = $adb->fetch_array($mnurs)) {
-		if ($mnu['mtype']=='menu') {
-			delMenuBranch($mnu['evvtmenuid']);
+	$mnurs = $adb->pquery('select evvtmenuid,mtype from vtiger_evvtmenu where mparent=?',array($topofbranch));
+	if ($mnurs and $adb->num_rows($mnurs)>0) {
+		while ($mnu = $adb->fetch_array($mnurs)) {
+			if ($mnu['mtype']=='menu') {
+				delMenuBranch($mnu['evvtmenuid']);
+			}
+			$adb->pquery('delete from vtiger_evvtmenu where evvtmenuid=?',array($mnu['evvtmenuid']));
 		}
-		$adb->pquery('delete from vtiger_evvtmenu where evvtmenuid=?',array($mnu['evvtmenuid']));
 	}
 	$adb->pquery('delete from vtiger_evvtmenu where evvtmenuid=?',array($topofbranch));
 }