Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageFind search gives not results for emojis #90

Open
Julianoe opened this issue Aug 29, 2023 · 4 comments
Open

PageFind search gives not results for emojis #90

Julianoe opened this issue Aug 29, 2023 · 4 comments

Comments

@Julianoe
Copy link

When using the search bar, there is no results for any emojis. My top emoji is 🔥 and I wanted to see the list of tweets containing it but it gives me "No results for 🔥".

@zachleat we seem to share the love for the use of emojis in content, and I'd love to be able to enable the indexation of emojis in my archive... if that's an option.

I suspect this is a PageFind issue, not a tweetback issue. If confirmed I can go point that out there.

@nhoizey
Copy link
Contributor

nhoizey commented Sep 5, 2023

@Julianoe thanks for opening the issue. I can confirm it also doesn't work in my own archive.

I couldn't find any issue in PageFind repo about emojis: https://github.com/CloudCannon/pagefind/issues?q=is%3Aissue+emoji

It doesn't work either on PageFind's demo: https://xkcd.pagefind.app/

A search for 🌋 should at least show this page: https://xkcd.pagefind.app/comics/2017-11-24-emoji-sports/

So I guess the best would be to open an issue in PageFind's repo.

@Julianoe
Copy link
Author

Julianoe commented Sep 5, 2023

👍 All right, I did not see that demo page to test it.
I'll go open an issue there then.

@bglw
Copy link

bglw commented Sep 13, 2023

👋 Hey all!

Pagefind v1.0.0 now has emoji support ✨ 👾 🚀 ❤️

@nhoizey
Copy link
Contributor

nhoizey commented Sep 14, 2023

Thanks a lot @bglw ! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants