bug #2040 handle Throwable (fprochazka)

This PR was merged into the 1.x branch. Discussion ---------- handle Throwable Related #2041 Commits ------- 99e9d1c handle Throwable
twigphp · May 30, 2016 · dad282f · dad282f
2 parents 3dfda00 + 99e9d1c
commit dad282f
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 0 deletions.
diff --git a/lib/Twig/Environment.php b/lib/Twig/Environment.php
@@ -438,6 +438,10 @@ public function createTemplate($template)
         } catch (Exception $e) {
             $this->setLoader($current);
 
+            throw $e;
+        } catch (Throwable $e) {
+            $this->setLoader($current);
+
             throw $e;
         }
         $this->setLoader($current);

diff --git a/lib/Twig/Node/Macro.php b/lib/Twig/Node/Macro.php
@@ -109,6 +109,11 @@ public function compile(Twig_Compiler $compiler)
             ->write("ob_end_clean();\n\n")
             ->write("throw \$e;\n")
             ->outdent()
+            ->write("} catch (Throwable \$e) {\n")
+            ->indent()
+            ->write("ob_end_clean();\n\n")
+            ->write("throw \$e;\n")
+            ->outdent()
             ->write("}\n\n")
             ->write("return ('' === \$tmp = ob_get_clean()) ? '' : new Twig_Markup(\$tmp, \$this->env->getCharset());\n")
             ->outdent()

diff --git a/lib/Twig/Template.php b/lib/Twig/Template.php
@@ -369,6 +369,12 @@ public function render(array $context)
                 ob_end_clean();
             }
 
+            throw $e;
+        } catch (Throwable $e) {
+            while (ob_get_level() > $level) {
+                ob_end_clean();
+            }
+
             throw $e;
         }
 

diff --git a/test/Twig/Tests/Node/MacroTest.php b/test/Twig/Tests/Node/MacroTest.php
@@ -58,6 +58,10 @@ public function getfoo(\$__foo__ = null, \$__bar__ = "Foo"$declaration)
     } catch (Exception \$e) {
         ob_end_clean();
 
+        throw \$e;
+    } catch (Throwable \$e) {
+        ob_end_clean();
+
         throw \$e;
     }