Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on the package 'humanfriendly' #6

Open
umayrh opened this issue Jan 27, 2019 · 0 comments
Open

Remove dependency on the package 'humanfriendly' #6

umayrh opened this issue Jan 27, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@umayrh
Copy link
Owner

umayrh commented Jan 27, 2019

Is your feature request related to a problem? Please describe.
Generally, it's desirable to keep package dependencies as lean as possible. We use humanfriendly to parse a strings like "50b", "100kb", and "250mb" and convert them to integer values. We should be able to remove this dependency by implementing the parse_size() function in util.py (see here).

Describe the solution you'd like
An implementation of parse_size in util.py and corresponding tests in test_util.py.

@umayrh umayrh added enhancement New feature or request good first issue Good for newcomers labels Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants