Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

radio-button improvements #246

Open
AndreJoaquim opened this issue May 2, 2018 · 0 comments
Open

radio-button improvements #246

AndreJoaquim opened this issue May 2, 2018 · 0 comments
Labels
enhancement

Comments

@AndreJoaquim
Copy link
Contributor

There are currently some issues with radio-button, including DDAU interactions.

I suggest two major improvements to be done to this component:

  • As in ember-radio-button, we are relying in DDAU to set the groupValue. We should always prevent the default event action and pass an action upwards with the changed data.

  • Add the possibility to yield content to the label to allow more customisable labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AndreJoaquim @migueldemoura