Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any feature to support "Topic"? #248

Open
strong84 opened this issue Oct 21, 2019 · 2 comments
Open

Is there any feature to support "Topic"? #248

strong84 opened this issue Oct 21, 2019 · 2 comments

Comments

@strong84
Copy link

Can user subscribe to a certain topic?
Use service as topic??

@TysonAndre
Copy link
Contributor

Can user subscribe to a certain topic?
Use service as topic??

No.

My thoughts on how this could be designed:

Right now, you'd have to implement that in the application using uniqush-push at the moment. If it was implemented, I assume uniqush-push would map "Topic" ids to a Redis ZSET of subscriber IDs (not device ids/tokens) and the date when the subscriber was added to the topic (or just a regular hash)

  • And subscribers+service could be mapped to set of topic IDs for quick lookup
  • Subscribers can have more than one device; Device ids/tokens can be reset.

Related to #12

I was planning to add an optional prefix that applications could use to store data associated with PSPs. However, that's more useful for individual devices (e.g. app version, locale), not the subscriber themselves.


Other miscellaneous thoughts:

  • The application would have a better idea of whether users were cancelled, what the display name of a user is, what text to use for different locales, what time windows where they'd prefer to receive pushes, etc. Instead of providing a way to push to every subscriber in a topic+service, provide an API that can be used to fetch subscribers (and devices?) of a topic, and paginate based on the time the subscriber was added to the ZSET for the topic

@strong84
Copy link
Author

If uniqush-push can support "Topic", it would be great.
But without "Topic", still, there are some workarounds.
I can use the push api to push to multiple subscribers. I think 10 maybe more subscribers maybe fine. but how about 100 more subscribers? the url will be extremely long. is there any potential performance bottle neck about this approach?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants