Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minify is broken when vanilla is not in the root #518

Closed
TiGR opened this issue Aug 15, 2010 · 2 comments
Closed

Minify is broken when vanilla is not in the root #518

TiGR opened this issue Aug 15, 2010 · 2 comments

Comments

@TiGR
Copy link
Contributor

TiGR commented Aug 15, 2010

Using latest git, new updates to minify break it when vanilla is installed not in the root. $Href contains full path, like "/vanilla/js/jquery.js", but PATH_ROOT also contains it, so concatenating them gives something like "/www/vanilla/vanilla/js/jquery.js", also base path is being passed to Minify as separate parameter, and since all hrefs contain that basepath, minify won't find any files.

Fix seems to be plain simple - in cutting basepath from $Href.
@linc
Copy link
Contributor

linc commented Feb 26, 2011

Could you check to see if d1666b7 fixes this?

@TiGR
Copy link
Contributor Author

TiGR commented Mar 1, 2011

Seems to be fixed. There is one problem though. Minify relies on environment a lot. Such as $_SERVER['DOCUMENT_ROOT']. This sometimes gets screwed up, and minify fails.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@linc @TiGR