Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for compression #55

Open
bridger opened this issue Feb 9, 2020 · 2 comments · May be fixed by #123
Open

Support for compression #55

bridger opened this issue Feb 9, 2020 · 2 comments · May be fixed by #123
Labels
enhancement New feature or request
Projects

Comments

@bridger
Copy link
Contributor

bridger commented Feb 9, 2020

I'm curious if compression support has been considered in this package. I'd be interested in using it in my server-side app.

Kitura developed this package for websocket compression which is also using NIO's websockets. Maybe it could be adapted to work with Vapor? https://github.com/IBM-Swift/Kitura-WebSocket-Compression

@tanner0101 tanner0101 added the enhancement New feature or request label Feb 12, 2020
@tanner0101 tanner0101 added this to To Do in Vapor 4 via automation Feb 12, 2020
@tanner0101
Copy link
Member

tanner0101 commented Feb 12, 2020

It looks like the only dependency that package has is SwiftNIO, so it would be possible to use that if WebSocketKit exposed some way to add additional handlers.

I wonder if this is something SwiftNIO would consider adopting. That would make it really easy for WebSocketKit to allow configuring compression like we do for HTTP: https://github.com/vapor/vapor/blob/master/Sources/Vapor/Server/HTTPServer.swift#L42

@bridger
Copy link
Contributor Author

bridger commented Feb 12, 2020

Yeah, I wasn’t sure if this is better at the NIO level or the library level that uses NIO. I’ll make another issue to ask there.

Sent with GitHawk

@MahdiBM MahdiBM linked a pull request Nov 16, 2022 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Vapor 4
  
Backlog
Development

Successfully merging a pull request may close this issue.

2 participants