Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine script for creating Ventoy EFI boot image #2670

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tsvenbla
Copy link

@tsvenbla tsvenbla commented Dec 7, 2023

  • Add a safeguard to exit the script if changing to the ISO directory fails, ensuring robustness in the script execution.
  • Format the mkisofs command for better readability by breaking it into multiple lines. This enhances the maintainability of the script.
  • Simplify the process of replacing the existing compressed EFI boot image in the INSTALL directory by removing the old file first and then copying the new one.

Note:
I did not test this refactored code. Merge only after testing.

- Add a safeguard to exit the script if changing to the ISO directory fails, ensuring robustness in the script execution.
- Format the `mkisofs` command for better readability by breaking it into multiple lines. This enhances the maintainability of the script.
- Simplify the process of replacing the existing compressed EFI boot image in the INSTALL directory by removing the old file first and then copying the new one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant