Rethink case sensitivity comparison for entities #1439
Labels
improvement
Improvement of an existing functionality. See "feature" for new features.
scope: core
Core VersionPress functionality like tracking actions, creating Git commits, etc.
Milestone
History:
ignored-entities
andfrequently-written
were originally compared as case-sensitive.QueryLanguageUtils::createRulesFromQueries
, see following commits: 2330858 and b54109f.strtolower()
inQueryLanguageUtils::createRulesFromQueries
andQueryLanguageUtils::entityMatchesSomeRule
.Plan:
QueryLanguageUtils::createRulesFromQueries
toandQueryLanguageUtils::entityMatchesSomeRule
toQueryLanguageUtils::createGitLogQueryFromRule
.ReplaceAfter movingstrtolower()
withmb_strtolower()
- values can be defined in different languages.strtolower()
only to keys (for filtering commits) we are safe here, I guess. I created issue Using multibyte string functions #1446 for future general inspection.$allowEmpty
is not used anywhere:versionpress/plugins/versionpress/src/Utils/QueryLanguageUtils.php
Line 24 in c916d7d
Tests:
entityMatchesRightQuery
andentityDoesntMatchWrongQuery
.assertEquals()
fromqueryLanguageUtilsCreatesCorrectRules
andqueryLanguageUtilsGeneratesCorrectGitLogQuery
and check if it works.Some tests fromYes, they are similar, butQueryLanguageUtilsTest
andEntityInfoTest
probably duplicates some assumptions now.EntityInfoTest
is testing wrapper functions likeisIgnoredEntity()
andEntityInfo
object, so they are not exact duplicates.The text was updated successfully, but these errors were encountered: