New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change tracking of actions as registered/anonymous #1449
base: master
Are you sure you want to change the base?
Conversation
REST requests are handled correctly now (when user is logged in) and there is no need for special method handleAsAdminSectionRoute().
Agreed. It currently looks like this in a Git commit:
I'd probably:
Something like:
("WordPress" is an idea after trying more obvious options like "Unknown", "Anonymous", "Non-user", "Unauthenticated" and similar; the word "WordPress" at least indicates that the commit was created by this CMS but I'm open to other options as well.) |
I am not sure about naming. I liked "Anonymous" initially, but what about "VersionPress" (commit was created by VersionPress)? Email |
I like the "VersionPress" suggestion, this is how it would look:
What do you think? BTW, are you comfortable enough trying to update the front-end as well? I think that the icon and tooltip are reasonable for now, just the detection should change to an email (and included the current |
Resolves #1442
Move from tracking admin/frontend actions to registered/anonymous, based on availability of registered WordPress user. It fixes problem for example with REST requests which are not generally depending on administration but authentication.
We should probably also change "Non-admin action" to something else, for example "Anonymous action"? @borekb
versionpress/plugins/versionpress/src/Git/Committer.php
Line 100 in e220983
And also add some back compatibility here?
versionpress/frontend/src/components/commits-table/commit-summary/Author.tsx
Line 21 in e220983