Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add token to metamask buttons #133

Open
2 tasks done
yellowgh0st opened this issue Dec 7, 2021 · 9 comments
Open
2 tasks done

Add token to metamask buttons #133

yellowgh0st opened this issue Dec 7, 2021 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@yellowgh0st
Copy link
Member

yellowgh0st commented Dec 7, 2021

  • VADER
  • xVADER
@Mervyn853
Copy link

Any updates on this for xVADER and VADER so users do not need to search for token contract address? @yellowgh0st

@yellowgh0st yellowgh0st self-assigned this Dec 23, 2021
@yellowgh0st yellowgh0st added the enhancement New feature or request label Dec 23, 2021
@yellowgh0st
Copy link
Member Author

Not yet adding to 2do

@dimorphic
Copy link
Contributor

#sneaky #wip ☯️👀

vader-tokens-wip

@yellowgh0st
Copy link
Member Author

@dimorphic are you on discord?

@dimorphic
Copy link
Contributor

@yellowgh0st : Aye, sir! @nyx . I'll ping you laterz, got some IRL duties to attend 🤖

@yellowgh0st
Copy link
Member Author

yellowgh0st commented Jan 7, 2022

Instead of a separate page, what would you think about a modal with such content that will pop up after the user takes specific actions such as stake/bond/swap/acquire/bond. In other words, a recommendation to add the token after stake/acquire/bond.

@dimorphic
Copy link
Contributor

I like the idea of recommendation to add, to enhance current / specific actions, a tooltip or something to remind the user.
But! I think the only fitting place to do this is in the staking tab & bond for now, more precise, 1st time staking Vader tokens. Because:

  1. Users that would come to stake V, would be already tracking V in their wallets (where do they get the info from?)
  2. If they do the approve & stake V steps, app should show them a recommendation to start tracking xV token, as most or even all won't be already tracking it prior staking, as not everyone stakes, knows of or even affords to do it up-front after acquiring V, they would rather get more V I guess and stake laterz. Still, they need the address to track in wallet...
  3. In Bonds maybe we can do the same, even if I think that ppl who get bonds already are tracking V
  4. In Acquire for sure, once that part is available

Otherwise, in the bond / acquire views, the user is most likely aware of both tokens and already interacted with the protocol in some way, thus most likely they would be already tracking both tokens, right? Am I missing something? :/

As I see it, users will look to add & track a custom token(s) into their wallets like so (abstract):

  1. Before acquiring a token
  2. After acquiring a token

So, considering numero #1 & #2 - most people will get Vader somehow, from somewhere (swap, CEX, etc) and have it delivered to their wallet. In this case, they don't interact / take a specific action in the Vader dApp that we can't track & act upon (currently no Eth/Vader swap in dApp besides Bonds kinda, but not rly). It doesn't apply for V token, but your suggestion sure does work for xV right after 1st time staking, to recommend it for add.

Still, it would be better to have the tokens listed somewhere right in the Vader dApp (as in the official links/sources) so the user can copy the contract address fast & add the custom token to his wallet and be done with it, just go 🚀 ; instead of opening some 3rd party site (in my case it was CMC) to lookup for the correct contract address. Should be official info in the dApp - visible and always reachable fast if you needz it, thus a page? #imo #ux Also, can we let them track the tokens without paying each time 300 🍌 in Eth gas fees to show a popup? 🤣 :D

As I said, I like the idea, but I think it's only fitting for the 1st time staking part (via local storage boolean), because sadly there's no way to check if some tokens are being tracked or not in a web3 wallet. :<

TL;DR; : do both, kinda. ¯_(ツ)_/¯

@yellowgh0st thoughts? Does it make any sense? (-.-)

@yellowgh0st
Copy link
Member Author

yellowgh0st commented Jan 8, 2022

Regards the recommendation cases you are right, my intention was only to briefly picture the idea.

Still, it would be better to have the tokens listed somewhere right in the Vader dApp (as in the official links/sources) so the user can copy the contract address fast & add the custom token to his wallet and be done with it, just go rocket ; instead of opening some 3rd party site (in my case it was CMC) to lookup for the correct contract address. Should be official info in the dApp - visible and always reachable fast if you needz it, thus a page? #imo #ux Also, can we let them track the tokens without paying each time 300 banana in Eth gas fees to show a popup? rofl :D

Yes, you're right, it's good information to have yet it is still secondary thing and unnecessary for users to operate the protocol. That header menu should be exclusive to primary functions in order to keep it clean and easy.
The user definitely doesn't pay any gas for pop-up or to track tokens. I'm not sure what do you mean by that part. They only pay if they submit contract interaction which most of the stuff on the UI is not.

I have created a wallet context menu where they can now import tokens. I recommend thinking about how in other ways this menu can be used to achieve what you describe to get the token information, like how we can design the menu item list, etc. The left top area provides potential space for more useful indicators.

I have also an idea that every token symbol might be treated as a sort of interactive tag that might do something when's hit eg. copy the address into the clipboard or store the token object somewhere.

@dimorphic
Copy link
Contributor

I agree the menu header should stay as clean as possible. 👍 I do like the wallet submenu you did, especially the disconnect button! It was needed and I wanted to add it also. :D The Eth gas was a joke regarding not having to interact with a contract to get the 'recommendation' popup. :) Anyways!

I already have a suggestion on how to combine these 2: keeping in mind that we wants clean header bar, I'd take the same approach with the wallet submenu too, keep it as clean as possible, bare minimum. It looks great on desktop, but on mobile devices, when in burger mode, currently it feels like i'm in some burger-menu-land-ception :D Like so (3 levels):

Screenshot 2022-01-08 at 03 34 35

I know, there's so much you can do in that much/little space and so many items to lists. So: the disconnect has to be there for sure, but I would merge your 2x '+' buttons into a single one 'Track in wallet' (no confusion with the 'add into wallet' - sounds less like deposit/funding this way maybe?) and have that route link redirect to the /tokens page view. This doesn't really solve the 'multi 3 level' problem in burger mode, but at least we keep the wallet submenu 'minimal' and navbar clear this way.

My proposal(s):

01-track-tokens-desktop.mp4
02-track-tokens-mobie.mp4

2x 🧠 = 🚀 go brrrrrr! :D

P.S.: bonus inc on Discord ☯️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants