[RSDK-7562] Add enablewebprofile to robot config #3934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
|
should we not just put the rest of the rdk changes in here too? so can test the flow end to end |
viambot
added
safe to test
viambot
added
safe to test
|
This is finally ready for review. App side for the config change https://github.com/viamrobotics/app/pull/4845 |
ale7714
changed the title
benjirewis
approved these changes
May 29, 2024
| @@ -195,7 +195,7 @@ func (s *robotServer) createWebOptions(cfg *config.Config) (weboptions.Options, | |||
| if err != nil { | |||
| return weboptions.Options{}, err | |||
| } | |||
| options.Pprof = s.args.WebProfile | |||
| options.Pprof = s.args.WebProfile || cfg.EnableWebProfile | |||
There was a problem hiding this comment.
[q] So if we run the RDK with -webprofile and put enable_webprofile: false in the JSON config, the web profile will still be enabled?
There was a problem hiding this comment.
Yes that's how it currently behaves. I think that behavior makes sense as in if I add the flag explicitly I expected to just work. Happy to change it if we end up finding this to be confusing.
There was a problem hiding this comment.
Cool; thanks! I think what you have now makes sense 👍🏻.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proto update here viamrobotics/api#497