DOCS-2317: Add motion service code snippets #3970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
|
Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!
|
viambot
added
safe to test
skyleilani
changed the title
viambot
added
safe to test
raybjork
approved these changes
May 30, 2024
services/motion/motion.go
Outdated
Comment on lines
195
to
205
| // geometriesInFrame := []*referenceframe.GeometriesInFrame{} | ||
| // | ||
| // worldState, _ := referenceframe.NewWorldState(geometriesInFrame, nil) | ||
| // |
There was a problem hiding this comment.
If you aren't making a worldState you can delete these and just pass nil into the Move function. If you want to include a worldstate then you should add geometries to it. I'm not sure if the motivation of these docs is to include a minimal example or an example utilizing all the fields
Thanks for all of the help with these! I see your comment and will definitely address it before merging. I appreciate your reviews! |
viambot
added
safe to test
skyleilani
force-pushed
the
DOCS-2228-Add-motion-service-code-snippets
branch
from
f37c1b9
to
e104461
Compare
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
andf-viam
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These code snippets were tested on a machine configured with real hardware Monday, 5/20. The purpose was to validate the functionality of these samples with the motion and SLAM services.
This error was thrown every time we tested the script. This error came up regardless of the method being called or the success of the method.