Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPServerRequest.fullURL value is incorrect if the request had passed through more than one HTTP proxy. #2702

Open
dbankov-vmware opened this issue Nov 25, 2022 · 0 comments

Comments

@dbankov-vmware
Copy link

HTTPServerRequest.fullURL tries to recreate the URL used on the client which resulted in the HTTPServerRequest taking into account the values of the "X-Forwarded-Host", "X-Forwarded-Proto" and "X-Forwarded-Port" headers which are updated by any HTTP proxy servers residing between the client and the server. The current implementation assumes that there is only one value in each of these headers however it is possible these to include multiple values in case the communication goes through more than one HTTP Proxy (which is the case when a vibe.d based service is executed in a Kubernetes deployment). The result is that fullURL returns an incorrect URL which makes this property unusable in a (Kubernetes) scenario with multiple HTTP Proxies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant