vim packages not being folded.

[Jeansen]

Description of issue

I am not able to fold packages.

Your description here!

Maybe I am missing something, but though I have set foldmethod=syntax and fiddled around with all the different settings, I get everything to work - except code-folding for packages.

E.g.:

package Null {
    my $null = bless {}, __PACKAGE__;
    sub AUTOLOAD {$null}
    sub ok       {0}
}

My settings:

let g:perl_fold = 1
let g:perl_include_pod = 1
let g:perl_extended_vars=1
let g:perl_fold_blocks = 1

I've also tried let g:perl_nofold_packages with 0/1, but no setting worked.

If it is a real bug, I'd definitely appreciate a fix :) If I just missed something, I would be grateful for any help.

[hoelzro]

Thanks for the bug report, @Jeansen! It seems that this form is folded:

package Null;

my $null = bless {}, __PACKAGE__;
sub AUTOLOAD {$null}
sub ok       {0}

But not the one you posted. Let's see if we can get that fixed!

[Jeansen]

Hey @hoelzro! Thank's for the quick answer. I would really appreciate a fix 😄 If I can be of support in any way, just let me know!

[hoelzro]

@Jeansen I just pushed some tests for "braced" packages - we could benefit from more tests (ex. package NAME VERSION { ... } is untested), and the implementation seems to have a bug with your exact example (for some reason the fold ends at sub ok). Also nice would be to add a CPAN module that uses brace packages to the corpus test, but that's something I'll probably need to do.

If you feel comfortable writing tests, that would be great - if you feel up to the challenge of debugging why the folding Vimscript isn't working, that would be even better!

[Jeansen]

@hoelzro Thank you. I'll have a look and see, what I can do. I am no Vimscript expert, but I'll take the challenge. But it might take some time.

[Jeansen]

@hoelzro I am not sure, if I am missing something, but when I use the following vimrc and try to fold the snippet from #251 (comment) then I do not see any change. Here's my minimalistic vimrc:

#!/usr/bin/vim

set encoding=utf-8
scriptencoding utf-8
set termencoding=utf-8
set shell=bash
filetype plugin indent on 
syntax on
set foldmethod=syntax

let g:perl_fold = 1
let g:perl_nofold_packages=0

call plug#begin('~/.vim/plugged')

Plug 'vim-perl/vim-perl', { 'branch': 'dev', 'for': 'perl', 'do': 'make clean carp dancer highlight-all-pragmas moose test-more try-tiny' }

call plug#end()

[hoelzro]

Hmm...looking at the code it turns out that setting perl_nofold_packages to anything will disable the folding; I'll fix that up in a bit!

[Jeansen]

Oh...well. Now I am ashamed to not have checked it myself 😊 Must be, because I am still in the Perl-Universe 😆

[Jeansen]

And yes, without perl_nofold_packages it works as described

[Jeansen]

I have made a PR with something working. Could you check, please? 😄

[Jeansen]

BTW, I noticed, that I have to delete my perl.vim in the vim home folder. Should it not be overwritten/overruled by the plugin installation?

[hoelzro]

It depends on how you're installing your plugins - if you're using something like Pathogen, for example, $HOME/.vim/syntax/perl.vim will take precedence over $HOME/.vim/bundle/vim-perl/syntax/perl.vim.

[hoelzro]

@Jeansen Sorry for the delay on this - I don't get a lot of time to work on vim-perl, and every time I do I feel like I'm just remembering where I was at! I believe I have fixed the package folding issue - could you grab what's on the dev branch and verify that it works?

[Jeansen]

@hoelzro No problem, same here ;) Backage folding issue seems to be resolved. Great work! Thank you 😃

[Jeansen]

Hey @hoelzro. I hope you are doing fine? After some months of absence, I finally found some time to get back to my project. Thou your fix solve some folding problems, it still is not doing everything as expected. It seems to be a bit too eager ;-)

If I use your current fix from the development branch and use syntax folding on https://github.com/Jeansen/cdmn/blob/master/cdmn , then some packages are recursively folded beneath package cdmn::math, though they are defined on the same level. That is,cdmn::contstants is folded beneath package cdmn::math. cdmn::proc is folded beneath cdmn::constants and so son.

Could you check again? I bet it is just a very little change that has to be done ;)