Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using trigger vs triggerHandler for custom editable events #86

Open
vladar opened this issue Jan 23, 2013 · 5 comments
Open

Consider using trigger vs triggerHandler for custom editable events #86

vladar opened this issue Jan 23, 2013 · 5 comments

Comments

@vladar
Copy link

vladar commented Jan 23, 2013

The problem I faced with is that triggerHandler doesn't bubble, so it's impossible to use event delegation with it.

I saw you added "selector" option recently, so enabling event delegation seems reasonable as well.

The only problem I envision is possible conflicts in event names with bootstrap, e.g. If I bind to bootstrap's modal "hidden" event and editable inside this modal triggers it's own "hidden" event - it will bubble up and trigger modal's handler.

Not sure how to handle this properly - maybe it's worth to namespace triggered events, but this will cause a BC break.

@vitalets
Copy link
Owner

Agree with all points. I think in major release to add namespace to events (that can be turned off by option for BC)
thank you!

@gordol
Copy link

gordol commented Jan 14, 2015

hmm... any progress on this? i'm having issues currently with trying to bind to .editable hidden event on dynamically added content. http://jsfiddle.net/rced7kp1/ perhaps someone has a work-around?

@gordol
Copy link

gordol commented Jan 14, 2015

so i got it sorted by patching x-editable to use trigger() instead of triggerhandler() for the hidden event. i imagine if i was putting editable items into overlays or something that would be problematic, but it seems to work fine for my uses.

@zamnuts
Copy link

zamnuts commented Mar 27, 2015

+1 on this enhancement, X-editable keeps all the goodies internal with triggerHandler :(

@gordol
Copy link

gordol commented Mar 27, 2015

#610 seems this project is basically abandoned

There are lots of forks and pull requests open, but nobody merging them back in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants