fixed faulty optimization

voloko · Oct 4, 2010 · 83af14d · 83af14d
1 parent 08601d0
commit 83af14d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/lib/twitter/json_stream.rb b/lib/twitter/json_stream.rb
@@ -189,7 +189,7 @@ def send_request
 
       content = @options[:content]
 
-      unless q = query.empty?
+      unless (q = query).empty?
         if @options[:method].to_s.upcase == 'GET'
           request_uri << "?#{q}"
         else

diff --git a/spec/twitter/json_stream.rb b/spec/twitter/json_stream.rb
@@ -60,6 +60,16 @@ def receive_data data
       $close_connection = false
     end
 
+    it "should add no params" do
+      connect_stream
+      $recieved_data.should include('/1/statuses/filter.json HTTP')
+    end
+
+    it "should add custom params" do
+      connect_stream :params => {:name => 'test'}
+      $recieved_data.should include('?name=test')
+    end
+
     it "should parse headers" do
       connect_stream
       stream.code.should == 200