Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Airplay state not changed to 'stop' after source disconnected #1903

Open
monte-monte opened this issue Feb 26, 2020 · 4 comments · May be fixed by #2005
Open

Airplay state not changed to 'stop' after source disconnected #1903

monte-monte opened this issue Feb 26, 2020 · 4 comments · May be fixed by #2005

Comments

@monte-monte
Copy link

Volumio version 2.712 (seen the same behavior in previous versions)

Problem: playing music from iPad via Airplay > switch back from Volumio to iPad or any other airplay device > Volumio's status remains 'play', seek state keeps counting into infinity. The only way is to start playing anything from playlist, or stop playing on iPad before disconnecting.

Expected behavior: Volumio detects airplay client disconnected and changes status to 'stop'.
@monte-monte monte-monte changed the title Airplay state not chcnged to 'stop' after source disconnected Airplay state not changed to 'stop' after source disconnected Feb 26, 2020
@monte-monte
Copy link
Author

Tried to set status to stop with volumio stop. Response was "response":"stop Success" but player state remained 'play' and even 'seek' time didn't reset.

@monte-monte
Copy link
Author

Okay, so Volumio ignores "ssnc" "pend" call that shairport-sync sends to metadata pipe, when client disconnects but it doesn't ignore it when client sends pause. Maybe this is because no metadata is sent before "ssnc" "pend", when client disconnects abruptly. If this is the case, I think we need to change how Volumio reads shairport's pipe.

elektro-wolle added a commit to elektro-wolle/Volumio2 that referenced this issue Oct 1, 2020
@elektro-wolle
Fix for volumio#1903
805cc6f 
After `pend` the state should switch to `pause`
@acresp
Copy link

acresp commented Jan 25, 2021 •
edited

The issue is still there in the last version 🙁 Just updated to 2.861
When an airplay client disconnect without pause, the volumio state stays on "play".

"status":"play"

And a cmd stop through the API doesn't change it to stop either 🙁

@elektro-wolle elektro-wolle linked a pull request Jan 25, 2021 that will close this issue
Open
@elektro-wolle
Copy link

@acresp The PR is still open... But you can add the line manually: see PR #2005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set Airplay state to 'stop' after source disconnected, see issue #1903 elektro-wolle/Volumio2
3 participants
@elektro-wolle @monte-monte @acresp