Do not require openvpn::client for client specific configs #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to require openvpn::client type as client configs don't rely on any of that type resources. It also not possible to use client_specific_config if extca_enabled is set to true for a server due to openvpn::client failure. Fixes voxpupuli#229 Signed-off-by: Anton Baranov <abaranov@linuxfoundation.org>
|
@spacedog thanks for the PR. Can you please rebase? |
|
Hi. I'm going to close this PR due to inactivity. Please reopen and rebase it if you're still interested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to require openvpn::client type as client configs
don't rely on any of that type resources. It also not possible to use
client_specific_config if extca_enabled is set to true for a server due
to openvpn::client failure.
Fixes #229
Signed-off-by: Anton Baranov abaranov@linuxfoundation.org