Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please fix postfix::relayhost parameter #295

Open
XMol opened this issue May 28, 2021 · 4 comments
Open

Please fix postfix::relayhost parameter #295

XMol opened this issue May 28, 2021 · 4 comments

Comments

@XMol
Copy link

XMol commented May 28, 2021

Hi,

as was already reported several years ago (#187), the postfix::relayhost parameter is meaningless. Unlike many other parameters, it is not looked up by postfix::files and therefor has no effect, which we discovered today.

I'd suggest to either remove the parameter and force people to include it in postfix::configs or to define Postfix::Config['relayhost'] themselves, or handle it in postfix::files, same as with four more parameters.

Thank you,
Xavier.

@raphink
Copy link
Member

raphink commented May 31, 2021

It seems that postfix::relayhost is used in postfix::mta:

https://github.com/camptocamp/puppet-postfix/blob/master/manifests/mta.pp#L40-L45

@XMol
Copy link
Author

XMol commented May 31, 2021

True, but we don't have postfix::mta in our catalog, which seemingly isn't mandatory. Including that - or postfix::satellite, which does the same - just to have relayhost included in main.cf cannot be the advised solution, right?

@DLeich
Copy link

DLeich commented Apr 13, 2022

I just got bit by this too. Was scratching my head trying to figure out why relayhost wasn't getting defined in main.cf. This appears to be why.

@sandynomad
Copy link

sandynomad commented Jun 1, 2022

Bump for this issue. It's defined in the documentation yet the implementation doesn't match the documentation.

For those who trip across this issue, to use a value from heira:

class { 'postfix':
}

postfix::config {
    'relayhost': value => lookup('postfix::relayhost', undef, undef, undef )
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants