Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haproxy_exporter: escape cnf_scrape_uri to avoid malformed strings #621

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

haproxy_exporter: escape cnf_scrape_uri to avoid malformed strings #621

wants to merge 2 commits into from

Conversation

Arnoways
Copy link

Pull Request (PR) description

Hello, this PR changes the way cnf_scrape_uri is being escaped in manifests/haproxy_exporter.pp to avoid malformed string like the one being described in Issue #600.

This Pull Request (PR) fixes the following issues

Fixes #600

@bastelfreak
Copy link
Member

Hi,
thanks for providing this PR. Could you add a unit test to verify this works as expected?

@bastelfreak bastelfreak added bug Something isn't working needs-tests labels Jun 6, 2022
@Arnoways
Copy link
Author

Arnoways commented Jun 8, 2022

Hi, thanks for providing this PR. Could you add a unit test to verify this works as expected?

Hello, I never done any tests in ruby so I hope this is what you expected. Let me know if you need something else 👍

1 similar comment
@Arnoways
Copy link
Author

Arnoways commented Jun 8, 2022

Hi, thanks for providing this PR. Could you add a unit test to verify this works as expected?

Hello, I never done any tests in ruby so I hope this is what you expected. Let me know if you need something else 👍

@bastelfreak
Copy link
Member

@Arnoways do you have any idea why the tests fail on Ubuntu 16?

@Arnoways
Copy link
Author

Arnoways commented Jun 8, 2022

@Arnoways do you have any idea why the tests fail on Ubuntu 16?

I have no idea. I don't see any relation between the errors and my modification. Do you think you can run them manually just in case ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
bug Something isn't working merge-conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extra double quotes in env file lead to invalid syntax
3 participants
@Arnoways @bastelfreak @TheMeier