Move the URL releases to their own directory under /opt to create the… #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaschaDoering
force-pushed
the
clean_old_url_releases
branch
from
7e52f28
to
521d843
Compare
|
Hi @SaschaDoering , thanks for the PR. Can you please add a unit test for this? Also an acceptance test would be helpful the verifies that the cleanup process is working. |
SaschaDoering
force-pushed
the
clean_old_url_releases
branch
3 times, most recently
from
a488036
to
7095b41
Compare
Move the URL releases to their own directory under /opt to create the possibility for Puppet to remove old releases that are no longer used.
SaschaDoering
force-pushed
the
clean_old_url_releases
branch
from
7095b41
to
9dd462d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the URL releases to their own directory under /opt to create the possibility for Puppet to remove old releases that are no longer used.
Pull Request (PR) description
In order to achieve that Puppet can clean up the directory in which Prometheus and the exporters are located, I have created a subdirectory under
/opt. This allows Puppet to purge the directory which would lead to unwanted behavior with/opt.However, this would reinstall all exporters once, which would require one-time manual clean-up. Then you can have that automatically.
So that the change is minimally invasive, I have the whole thing activated via a variable that is deactivated by default.
Please let me know if anything is missing or if my approach does not fit.
This Pull Request (PR) fixes the following issues
Fixes #625