Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ggbiplot() now available on CRAN in another package as AMR::ggplot_pca() #62

Open
msberends opened this issue Apr 17, 2020 · 1 comment

Comments

@msberends
Copy link

msberends commented Apr 17, 2020

Just to let you know: the code of the ggbiplot() function of this package as developed over 5 years ago, was used by us to create the ggplot_pca() function for the AMR package. An update containing this function is now available on CRAN and we maintain it actively. Many thanks for your work, Vince Vu!

Under Source, we tried our best to give proper attribution so there we state:

Source

The ggplot_pca() function is based on the ggbiplot() function from the ggbiplot package by Vince Vu, as found on GitHub: https://github.com/vqv/ggbiplot (retrieved: 2 March 2020, their latest commit: 7325e88; 12 February 2015).

As per their GPL-2 licence that demands documentation of code changes, the changes made based on the source code were:

  1. Rewritten code to remove the dependency on packages plyr, scales and grid
  2. Parametrised more options, like arrow and ellipse settings
  3. Hardened all input possibilities by defining the exact type of user input for every argument
  4. Added total amount of explained variance as a caption in the plot
  5. Cleaned all syntax based on the lintr package, fixed grammatical errors and added integrity checks
  6. Updated documentation

Our source code for the ggplot_pca() function is available here on GitHub.

This also 'solves' issues #61, #60, #57, #56, #53, #52, #51, #49, #34, #72 and probably more.

@VLucet
Copy link

VLucet commented Feb 26, 2022

Awesome, didn't know about that, thanks for posting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants