All Examples: Add "use strict" and lint rule (pull #1416)

* add strict mode and fix all errors * fix linting errors * Fix menubar * Declare undeclared variables in tabs Co-authored-by: Valerie Young <valerie@bocoup.com>
w3c · Jun 25, 2020 · 2ddb55d · 2ddb55d
1 parent f2358c6
commit 2ddb55d
Show file tree

Hide file tree

Showing 88 changed files with 211 additions and 33 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -12,6 +12,7 @@
     "no-restricted-properties": [2, {
       "property": "findElements",
       "message": "Please use t.context.queryElements()."
-    }]
+    }],
+    "strict": [2, "global"]
   }
 }
diff --git a/examples/alert/js/alert.js b/examples/alert/js/alert.js
@@ -3,6 +3,9 @@
 *   https://www.w3.org/Consortium/Legal/2015/copyright-software-and-document
 *
 */
+
+'use strict';
+
 window.addEventListener('load', function () {
 
   var button = document.getElementById('alert-trigger');

diff --git a/examples/button/js/button.js b/examples/button/js/button.js
@@ -5,6 +5,8 @@
 *   JS code for the button design pattern
 */
 
+'use strict';
+
 var ICON_MUTE_URL = 'images/mute.svg#icon-mute';
 var ICON_SOUND_URL = 'images/mute.svg#icon-sound';
 

diff --git a/examples/button/js/button_idl.js b/examples/button/js/button_idl.js
@@ -5,6 +5,8 @@
 *   JS code for the button design pattern using the new ARIA 1.2 IDL for reflection.
 */
 
+'use strict';
+
 var ICON_MUTE_URL = 'images/mute.svg#icon-mute';
 var ICON_SOUND_URL = 'images/mute.svg#icon-sound';
 

diff --git a/examples/carousel/js/carousel-tablist.js b/examples/carousel/js/carousel-tablist.js
@@ -5,6 +5,8 @@
 *
 */
 
+'use strict';
+
 // takes options object: { accessibleCaptions: boolean, autoplay: boolean, playButton: boolean }
 // defaults are: { accessibleCaptions: true, autoplay: false, playButton: true }
 

diff --git a/examples/carousel/js/carousel.js b/examples/carousel/js/carousel.js
@@ -5,6 +5,8 @@
 *
 */
 
+'use strict';
+
 /*
 *   @constructor CarouselTablist
 *

diff --git a/examples/carousel/js/carouselButtons.js b/examples/carousel/js/carouselButtons.js
@@ -4,6 +4,8 @@
 *   Desc:   Carousel Button widget that implements ARIA Authoring Practices
 */
 
+'use strict';
+
 /*
 *   @constructor CarouselButton
 *

diff --git a/examples/carousel/js/carouselItem.js b/examples/carousel/js/carouselItem.js
@@ -4,6 +4,8 @@
 *   Desc:   Carousel Tab widget that implements ARIA Authoring Practices
 */
 
+'use strict';
+
 /*
 *   @constructor CarouselItem
 *

diff --git a/examples/carousel/js/pauseButton.js b/examples/carousel/js/pauseButton.js
@@ -5,6 +5,8 @@
 *
 */
 
+'use strict';
+
 var PauseButton = function (domNode, carouselObj) {
   this.domNode = domNode;
 

diff --git a/examples/checkbox/checkbox-1/js/checkbox.js b/examples/checkbox/checkbox-1/js/checkbox.js
@@ -9,6 +9,8 @@
 *
 */
 
+'use strict';
+
 /*
 *   @constructor Checkbox
 *

diff --git a/examples/checkbox/checkbox-2/js/checkboxMixed.js b/examples/checkbox/checkbox-2/js/checkboxMixed.js
@@ -8,6 +8,8 @@
 *           for a menu of links
 */
 
+'use strict';
+
 /*
 *   @constructor CheckboxMixed
 *

diff --git a/examples/checkbox/checkbox-2/js/controlledCheckbox.js b/examples/checkbox/checkbox-2/js/controlledCheckbox.js
@@ -8,6 +8,8 @@
 *           for a mixed checkbox
 */
 
+'use strict';
+
 /*
 *   @constructor ControlledCheckbox
 *

diff --git a/examples/combobox/js/combobox-autocomplete.js b/examples/combobox/js/combobox-autocomplete.js
@@ -2,6 +2,9 @@
 *   This content is licensed according to the W3C Software License at
 *   https://www.w3.org/Consortium/Legal/2015/copyright-software-and-document
 */
+
+'use strict';
+
 var ComboboxAutocomplete = function (comboboxNode, buttonNode, listboxNode) {
 
   this.comboboxNode = comboboxNode;

diff --git a/examples/combobox/js/grid-combo-example.js b/examples/combobox/js/grid-combo-example.js
@@ -5,6 +5,8 @@
 * ARIA Combobox Examples
 */
 
+'use strict';
+
 var FRUITS_AND_VEGGIES = [
   ['Apple', 'Fruit'],
   ['Artichoke', 'Vegetable'],

diff --git a/examples/combobox/js/grid-combo.js b/examples/combobox/js/grid-combo.js
@@ -3,6 +3,8 @@
 *   https://www.w3.org/Consortium/Legal/2015/copyright-software-and-document
 */
 
+'use strict';
+
 /**
  * @constructor
  *

diff --git a/examples/dialog-modal/js/alertdialog.js b/examples/dialog-modal/js/alertdialog.js
@@ -1,3 +1,5 @@
+'use strict';
+
 var aria = aria || {};
 
 aria.Utils = aria.Utils || {};

diff --git a/examples/dialog-modal/js/calendar-button.js b/examples/dialog-modal/js/calendar-button.js
@@ -5,6 +5,8 @@
 *   File:   calendar-button.js
 */
 
+'use strict';
+
 var DatePicker = DatePicker || {};
 
 var CalendarButtonInput = function (inputNode, buttonNode, datepicker) {

diff --git a/examples/dialog-modal/js/datepicker-day.js b/examples/dialog-modal/js/datepicker-day.js
@@ -5,6 +5,8 @@
 *   File:   datepickerDay.js
 */
 
+'use strict';
+
 var DatePickerDay = function (domNode, datepicker, index, row, column) {
 
   this.index = index;

diff --git a/examples/dialog-modal/js/datepicker.js b/examples/dialog-modal/js/datepicker.js
@@ -5,6 +5,8 @@
 *   File:   datepicker.js
 */
 
+'use strict';
+
 var CalendarButtonInput = CalendarButtonInput || {};
 var DatePickerDay = DatePickerDay || {};
 

diff --git a/examples/dialog-modal/js/dialog.js b/examples/dialog-modal/js/dialog.js
@@ -3,6 +3,8 @@
 *   https://www.w3.org/Consortium/Legal/2015/copyright-software-and-document
 */
 
+'use strict';
+
 var aria = aria || {};
 
 aria.Utils = aria.Utils || {};

diff --git a/examples/disclosure/js/disclosureButton.js b/examples/disclosure/js/disclosureButton.js
@@ -8,6 +8,8 @@
 *           for a menu of links
 */
 
+'use strict';
+
 /*
 *   @constructor ButtonExpand
 *

diff --git a/examples/disclosure/js/disclosureMenu.js b/examples/disclosure/js/disclosureMenu.js
@@ -5,6 +5,7 @@
 *   Supplemental JS for the disclosure menu keyboard behavior
 */
 
+'use strict';
 
 var DisclosureNav = function (domNode) {
   this.rootNode = domNode;

diff --git a/examples/feed/js/feed.js b/examples/feed/js/feed.js
@@ -3,6 +3,8 @@
 *   https://www.w3.org/Consortium/Legal/2015/copyright-software-and-document
 */
 
+'use strict';
+
 /**
  * @namespace aria
  */

diff --git a/examples/feed/js/feedDisplay.js b/examples/feed/js/feedDisplay.js
@@ -3,6 +3,8 @@
 *   https://www.w3.org/Consortium/Legal/2015/copyright-software-and-document
 */
 
+'use strict';
+
 /**
  * @namespace aria
  */

diff --git a/examples/feed/js/main.js b/examples/feed/js/main.js
@@ -3,6 +3,8 @@
 *   https://www.w3.org/Consortium/Legal/2015/copyright-software-and-document
 */
 
+'use strict';
+
 /**
  * ARIA Feed Example
  * @function onload

diff --git a/examples/grid/js/dataGrid.js b/examples/grid/js/dataGrid.js
@@ -3,6 +3,8 @@
 *   https://www.w3.org/Consortium/Legal/2015/copyright-software-and-document
 */
 
+'use strict';
+
 /**
  * @namespace aria
  */

diff --git a/examples/grid/js/dataGrids.js b/examples/grid/js/dataGrids.js
@@ -2,6 +2,9 @@
 *   This content is licensed according to the W3C Software License at
 *   https://www.w3.org/Consortium/Legal/2015/copyright-software-and-document
 */
+
+'use strict';
+
 /**
  * ARIA Grid Examples
  * @function onload

diff --git a/examples/grid/js/layoutGrids.js b/examples/grid/js/layoutGrids.js
@@ -2,6 +2,9 @@
 *   This content is licensed according to the W3C Software License at
 *   https://www.w3.org/Consortium/Legal/2015/copyright-software-and-document
 */
+
+'use strict';
+
 var aria = aria || {};
 
 /**

diff --git a/examples/grid/js/menuButton.js b/examples/grid/js/menuButton.js
@@ -4,6 +4,8 @@
 *
 */
 
+'use strict';
+
 /**
  * ARIA Menu Button example
  * @function onload

diff --git a/examples/js/app.js b/examples/js/app.js
@@ -1,3 +1,4 @@
+'use strict';
 (function () {
   // Load syntax highlighting
   hljs.initHighlightingOnLoad();

diff --git a/examples/js/examples.js b/examples/js/examples.js
@@ -2,6 +2,8 @@
  * @namespace aria
  */
 
+'use strict';
+
 var aria = aria || {};
 
 /* ---------------------------------------------------------------- */

diff --git a/examples/js/utils.js b/examples/js/utils.js
@@ -1,3 +1,4 @@
+'use strict';
 /**
  * @namespace aria
  */

diff --git a/examples/landmarks/js/bootstrap-accessibility-2.js b/examples/landmarks/js/bootstrap-accessibility-2.js
@@ -15,6 +15,8 @@
  * limitations under the License.
  */
 
+'use strict';
+
 // Removes the "tablist" role from bootstrap.js "nav" class objects
 $(document).ready(function (e) {
   $('ul.nav-stacked').removeAttr('role');

diff --git a/examples/landmarks/js/show.js b/examples/landmarks/js/show.js
@@ -15,6 +15,8 @@
  * limitations under the License.
  */
 
+'use strict';
+
 function showLandmarks (event) {
   if (typeof window[initLandmarks] !== 'function') {
     window[initLandmarks] = initLandmarks();

diff --git a/examples/landmarks/js/tabs.js b/examples/landmarks/js/tabs.js
@@ -15,6 +15,8 @@
  * limitations under the License.
  */
 
+'use strict';
+
 $('#myTabs a').click(function (e) {
   e.preventDefault();
   $(this).tab('show');

diff --git a/examples/link/js/link.js b/examples/link/js/link.js
@@ -2,6 +2,9 @@
 *   This content is licensed according to the W3C Software License at
 *   https://www.w3.org/Consortium/Legal/2015/copyright-software-and-document
 */
+
+'use strict';
+
 function goToLink (event, url) {
   var type = event.type;
 

diff --git a/examples/listbox/js/listbox-collapsible.js b/examples/listbox/js/listbox-collapsible.js
@@ -1,3 +1,4 @@
+'use strict';
 /**
  * ARIA Collapsible Dropdown Listbox Example
  * @function onload

diff --git a/examples/listbox/js/listbox-rearrangeable.js b/examples/listbox/js/listbox-rearrangeable.js
@@ -2,6 +2,9 @@
 *   This content is licensed according to the W3C Software License at
 *   https://www.w3.org/Consortium/Legal/2015/copyright-software-and-document
 */
+
+'use strict';
+
 /**
  * ARIA Listbox Examples
  * @function onload

diff --git a/examples/listbox/js/listbox-scrollable.js b/examples/listbox/js/listbox-scrollable.js
@@ -2,6 +2,9 @@
 *   This content is licensed according to the W3C Software License at
 *   https://www.w3.org/Consortium/Legal/2015/copyright-software-and-document
 */
+
+'use strict';
+
 /**
  * ARIA Scrollable Listbox Example
  * @function onload

diff --git a/examples/listbox/js/listbox.js b/examples/listbox/js/listbox.js
@@ -2,6 +2,9 @@
 *   This content is licensed according to the W3C Software License at
 *   https://www.w3.org/Consortium/Legal/2015/copyright-software-and-document
 */
+
+'use strict';
+
 /**
  * @namespace aria
  */

diff --git a/examples/listbox/js/toolbar.js b/examples/listbox/js/toolbar.js
@@ -2,6 +2,9 @@
 *   This content is licensed according to the W3C Software License at
 *   https://www.w3.org/Consortium/Legal/2015/copyright-software-and-document
 */
+
+'use strict';
+
 /**
  * @namespace aria
  */

diff --git a/examples/menu-button/js/MenuItemAction.js b/examples/menu-button/js/MenuItemAction.js
@@ -7,6 +7,8 @@
 *   Desc:   Popup Menu Menuitem widget that implements ARIA Authoring Practices
 */
 
+'use strict';
+
 /*
 *   @constructor MenuItem
 *

diff --git a/examples/menu-button/js/MenuItemActionActivedescendant.js b/examples/menu-button/js/MenuItemActionActivedescendant.js
@@ -7,6 +7,8 @@
 *   Desc:   Popup Menu Menuitem widget that implements ARIA Authoring Practices
 */
 
+'use strict';
+
 /*
 *   @constructor MenuItem
 *

diff --git a/examples/menu-button/js/MenuItemLinks.js b/examples/menu-button/js/MenuItemLinks.js
@@ -7,6 +7,8 @@
 *   Desc:   Popup Menu Menuitem widget that implements ARIA Authoring Practices
 */
 
+'use strict';
+
 /*
 *   @constructor MenuItemLinks
 *

diff --git a/examples/menu-button/js/Menubutton.js b/examples/menu-button/js/Menubutton.js
@@ -7,6 +7,8 @@
 *   Desc:   Menubutton widget that implements ARIA Authoring Practices
 */
 
+'use strict';
+
 /*
 *   @constructor MenuButton
 *