Skip to content

Commit

Permalink
Infrastructure: Check vnu-jar warnings in addition to errors (pull #1671
Browse files Browse the repository at this point in the history
)

* Check for VNU warnings
* Turn off all current warnings in the config
* fix: remove "type" from style tags
* fix: role="main" on main element
* chore: Add tracking issues for validator warnings
  • Loading branch information
nschonni committed Feb 27, 2021
1 parent 56cff78 commit 8d888d4
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 4 deletions.
8 changes: 8 additions & 0 deletions .vnurc
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,11 @@ Attribute “aria-posinset” not allowed on element “tr” at this point.
Attribute “aria-setsize” not allowed on element “tr” at this point.
# Ignoring role meter
Bad value “meter” for attribute “role” on element “div”.
# https://github.com/w3c/aria-practices/issues/1675
The “type” attribute is unnecessary for JavaScript resources.
# https://github.com/w3c/aria-practices/issues/1676
The “row” role is unnecessary for element “tr”.
# https://github.com/w3c/aria-practices/issues/1677
Attribute “aria-activedescendant” value should either refer to a descendant element, or should be accompanied by attribute “aria-owns”.
# https://github.com/w3c/aria-practices/issues/1678
Section lacks heading. Consider using “h2”-“h6” elements to add identifying headings to all sections.
2 changes: 1 addition & 1 deletion examples/landmarks/form.html
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<link href="css/bootstrap-accessibility.css" rel="stylesheet" media="screen"/>
<link href="css/visua11y.css" rel="stylesheet" media="screen"/>
<link href="css/common.css" rel="stylesheet" media="screen"/>
<style type="text/css">
<style>
label,
input[type=submit] {
display: block;
Expand Down
2 changes: 1 addition & 1 deletion examples/radio/radio-activedescendant.html
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<li><a href="../../#radiobutton">Design Pattern</a></li>
</ul>
</nav>
<main role="main">
<main>
<h1>Radio Group Example Using aria-activedescendant</h1>
<p>
This example implements the features of the <a href="../../#radiobutton">Radio Group Design Pattern</a>
Expand Down
2 changes: 1 addition & 1 deletion examples/radio/radio.html
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<li><a href="../../#radiobutton">Design Pattern</a></li>
</ul>
</nav>
<main role="main">
<main>
<h1>Radio Group Example Using Roving tabindex</h1>
<p>
This example implements the features of the <a href="../../#radiobutton">Radio Group Design Pattern</a>
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"regression": "ava --timeout=1m",
"regression-report": "node test/util/report",
"test": "npm run lint && npm run regression",
"vnu-jar": "java -jar node_modules/vnu-jar/build/dist/vnu.jar --errors-only --filterfile .vnurc --no-langdetect --skip-non-html aria-practices.html examples/",
"vnu-jar": "java -jar node_modules/vnu-jar/build/dist/vnu.jar --filterfile .vnurc --no-langdetect --skip-non-html aria-practices.html examples/",
"create-gh-project": "node ./scripts/create-gh-project.js",
"postinstall": "husky install",
"prepublishOnly": "pinst --disable",
Expand Down

0 comments on commit 8d888d4

Please sign in to comment.