add quadratic funding pallet milestone-1

[zhangjiannan]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• The invoice form 📝 has been filled out for this milestone.
• This pull request is done by the same account, which is responsible for the pull request of the accepted application.
• In the case of acceptance, the payment will be transferred to the initial BTC payment address.
• The delivery is according to the milestone delivery guidelines.

[zhangjiannan]

How can I pass the checks?

[semuelle]

The check is just a bot writing your delivery data into a database. No need to worry about it.

[Noc2]

Thanks again for the delivery. I started to look into it and have a few questions/requests:

• Could you update the readme? It’s currently just the original readme of the substrate-node-template and doesn’t contain any information about your document or a testing guide, see
• Your current pallet has a few unused variables, functions, etc. Could you clean this up?
• You should ensure that the name has a limited size: https://github.com/zhangjiannan/QFgrant/blob/main/pallets/quadratic-funding/src/lib.rs#L186
• It would be nice if you could provide inline documentation for all the functions.
• How do I start a round? I only found end_round: https://github.com/zhangjiannan/QFgrant/blob/199b61301975653adb3dda8e53a36c3ccab85503/pallets/quadratic-funding/src/lib.rs#L161

[zhangjiannan]

@Noc2 thanks for your feedback. We have made changes in the repo.

• updated readme
• updated unit tests in test.rs
• fixed warnings and glitches
• provided in-line documentation
• added start_round function and now the pallet supports multiple rounds

[Noc2]

Sorry for the late response. This looks much better. Just a quick follow-up: Could you still provide a small testing guide or tutorial? I quickly tried to play with it via the extrinsics tab of polkadot.js, but for example didn’t immediately know how the Admin set up works (or which accounts I need to use to start a round). And could you point me to line in the code that calculates the matched amounts or payment to each project based on quadratic funding? (You can find a python implementation here: https://github.com/gitcoinco/quadratic-funding)

[zhangjiannan]

@Noc2 Thanks for feedback. We are not exactly following GitCoin's approach, we are mostly migrating a decentralized version of quadratic funding grant currently running on HackerLink (see BSC Grant Round-1 https://hackerlink.io/en/Grant/BSC/Round/1/detail), and the algorithm follows Vitalik's original paper (https://vitalik.ca/general/2019/12/07/quadratic.html). The fund distribution happens within fn end_round(), and it's based on each project's support area within a round. We will provide more documentation and in-line comments to help navigate shortly.

[mmagician]

I'm putting this temporarily on hold due to parallel participation in the hackathon. The hackathon organisers will contact you regarding further steps.

[Noc2]

@zhangjiannan Any update on this. Should I take another look at the delivery

[zhangjiannan]

Hi @Noc2 we have developed a frontend and integrated into HackerLink. I will share a demo video to help better understand the pallet soon.

[Noc2]

@zhangjiannan I just took another quick look at it. Looks good, could you also integrate the json for polkadot.js into the testing guide: https://github.com/zhangjiannan/QFgrant/blob/main/doc/test-guide.md?

[zhangjiannan]

Hi @Noc2 the json has been added to decode round and project . We deployed a node for testing, you can access it using custom endpoint wss://dao.tophacker.com.

[Noc2]

I’m happy to tell you that the milestone is a pass. You can find my evaluation here. However, I noticed that the payment address on the invoice is different from the original contract. Could you either amend the payment address of the contract or send us a new invoice?

[Noc2]

@zhangjiannan The invoice team just paid you, see https://etherscan.io/tx/0x81b8bbc0a1531a0a4d880c6a59aafb055bc2c2e16daf9f8aa5da66bf7b609a00