Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default db migration behavior should be to use migrations from current source #112

Open
akajla09 opened this issue May 4, 2023 · 0 comments
Labels
datastore Requires changes in the datastore layer

Comments

@akajla09
Copy link
Member

akajla09 commented May 4, 2023

Describe the bug
Currently, the default for go-migrate is to pull db migrations directly from Github (main branch) and run them (including with the autoMigrate flag). This means that you could potentially have a mismatch between the migrations being run and the server code if it is not up to date.

Expected behavior
Only the migrations up to the current version of source (whether built locally or pre-built) should run. This might mean packaging the migrations along with the binary.

@akajla09 akajla09 added the datastore Requires changes in the datastore layer label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datastore Requires changes in the datastore layer
Projects
None yet
Development

No branches or pull requests

1 participant