Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add this to Symfony? #41

Open
JPustkuchen opened this issue Jun 30, 2022 · 2 comments
Open

Add this to Symfony? #41

JPustkuchen opened this issue Jun 30, 2022 · 2 comments

Comments

@JPustkuchen
Copy link

Hi @wasinger,

we just ran into the same issue, looking for a simple way to manipulate DOM in PHP in the year 2022... crazy hard.
I found this old Symfony issue: symfony/symfony#8036

Wouldn't it perhaps make sense to ask the Symfony team to add your great tool to Symfony as extension to the Crawler?

As PHP doesn't provide such a functionality and this is already Symfony-based and Crawler is a large step into this direction, it would be straighforward, if Symfony could remove this pain... What do you think? Or did you already contact Symfony or @fabpot?

@wasinger
Copy link
Owner

wasinger commented Jul 8, 2022

I wouldn't mind integrating this library into Symfony. But since the Symfony devs have clearly expressed that this is not the focus of the crawler component of Symfony, I don't expect this to happen.
However, it would be helpful to include a reference to HtmlPageDom in the Symfony crawler documentation.

@JPustkuchen
Copy link
Author

Thanks for your quick reply and positive response @wasinger, I totally agree. And thanks for this great project :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants