Improves MJPEG video encoding #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raspberrypi/userland#208, the MJPEG encoder may deadlock if the FIFO is full on shutdown. This change increases the encoder buffer size, which helps to keep the FIFO size down. With this change, the following program exits cleanly. Previously, it would lock up the camera, requiring a reboot. import picamera import time camera = picamera.PiCamera() camera.resolution = (1296, 972) camera.framerate = 15 camera.start_recording('test.mjpeg', format='mjpeg', quality=0) time.sleep(5) camera.stop_recording()
waveform80
added a commit
that referenced
this pull request
Nov 29, 2014
Improves MJPEG video encoding
|
Excellent - many thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in raspberrypi/userland#208, the MJPEG encoder may deadlock
if the FIFO is full on shutdown. This change increases the encoder buffer size,
which helps to keep the FIFO size down.
With this change, the following program exits cleanly. Previously, it would
lock up the camera, requiring a reboot.
import picamera
import time
camera = picamera.PiCamera()
camera.resolution = (1296, 972)
camera.framerate = 15
camera.start_recording('test.mjpeg', format='mjpeg', quality=0)
time.sleep(5)
camera.stop_recording()