Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document webpack change: feat: add colors flag to infrastructureLogging #4818

Closed
webpack-bot opened this issue Apr 6, 2021 · 3 comments · Fixed by #4853
Closed

Document webpack change: feat: add colors flag to infrastructureLogging #4818

webpack-bot opened this issue Apr 6, 2021 · 3 comments · Fixed by #4853

Comments

@webpack-bot
Copy link

A pull request by @KENNYSOFT was merged and maintainers requested a documentation change.

See pull request: webpack/webpack#13051


Fixes #12899

Since it's my first try of contribution to webpack, even if I looked carefully for impacted default values etc, there can exists some missed parts. Please review carefully for me to fix things. Thanks!

What kind of change does this PR introduce?

feature

Did you add tests for your changes?

Yes

Does this PR introduce a breaking change?

No

What needs to be documented once your changes are merged?

  • infrastructureLogging.colors Enables/Disables colorful output.
  • infrastructureLogging.appendOnly Only appends lines to the output. Avoids updating existing output e. g. for status messages.
  • infrastructureLogging.stream Stream used for logging output. Defaults to process.stderr.
  • infrastructureLogging.console Custom console used for logging.
  • When stream is an TTY colors is enabled and appendOnly is disabled. Otherwise it's flipped.
@snitin315
Copy link
Member

I will document it.

@chenxsan
Copy link
Member

@snitin315 Any progress?

@snitin315
Copy link
Member

Thanks for the ping , I will send PR in near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants