Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idea: set favicon to webxdc's icon #2

Open
Simon-Laux opened this issue Jun 19, 2022 · 1 comment
Open

idea: set favicon to webxdc's icon #2

Simon-Laux opened this issue Jun 19, 2022 · 1 comment

Comments

@Simon-Laux
Copy link
Contributor

Simon-Laux commented Jun 19, 2022

might need some conversion from png/jpg to ico, to use the fact that browsers look for favicon.ico
If that would work we don't need to inject any header html tags, which might be more complicated, but on the other hand then we could probably save the format conversion step?

@Simon-Laux Simon-Laux changed the title idea: set favicon to app icon idea: set favicon to webxdc's icon Jun 19, 2022
@faassen
Copy link
Collaborator

faassen commented Jun 20, 2022

Is this about the favicon of the instance tabs in particular? I think it should be possible to implement something that injects a favicon.ico based on the icon.png/icon.jpg file in the webxdc application directory.

Need a bit of research to see whether there's some kind of easy conversion library we can plug into.

We could convert the resource in memory on demand, which would perhaps be simplest at the cost of reconverting each time a tab is opened I think. Though it'd be easy enough to set a cache header to avoid that. Though perhaps that doesn't work on localhost. Alternatively we can put the conversion output in a special directory in tmp and layer it in using express static.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants