Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label not creating when upsteam branch updates more than once within [Pull]PR opened period #445

Open
michaeljin89757 opened this issue May 23, 2022 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@michaeljin89757
Copy link

image
michaeljin89757/BoTest#3

image
michaeljin89757/BoTest#2

As shown in pictures above, when there are updates happened within [Pull]PR opened period the pull bot did not create the pull label as expected.

@michaeljin89757 michaeljin89757 changed the title Label not creating when upsteam branch updated more than once within [Pull]PR opened period Label not creating when upsteam branch updates more than once within [Pull]PR opened period May 23, 2022
@wei
Copy link
Owner

wei commented May 25, 2022

Hi @michaeljin89757 thanks for the report!

The label should have been added as soon as the PR is created.

In the PR you shared, we can see that this update snippet did not work because the PR body was not updated and the tag also not added:

pull/lib/pull.js

Lines 198 to 205 in f5d246c

await this.github.issues.update({
owner: this.config.owner,
repo: this.config.repo,
issue_number: createdPR.data.number,
assignees,
labels: [this.config.label],
body: helper.getPRBody(this.config.repoPath, prNumber)
})

The only thing I can think of is GitHub taking its time to calculate mergability state and causing updates to the PR to fail. I need to step through and see if this is the case and report to GitHub. Thanks again!

If anyone can help reproduce this with maybe a couple curls, that would help me tremendously!

@wei wei added bug Something isn't working good first issue Good for newcomers labels May 25, 2022
@Drez4754
Copy link

Drez4754 commented Dec 3, 2022

The only thing I can think of is GitHub taking its time to calculate mergability state and causing updates to the PR to fail. Or it's not creating PR and not processing the rest of the commands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants