Solaris Studio 12.3 and 12.4 builds broken

[noloader]

Andrew Marlow and Shengli Jiang report on the mailing list:

"ida.cpp", line 403: Error: random_access_iterator_tag is not defined.
"ida.cpp", line 403: Error: "," expected instead of ">".
"ida.cpp", line 407: Error: The function "RevIt" must have a prototype.
"ida.cpp", line 407: Error: The function "RevIt" must have a prototype.
"ida.cpp", line 407: Error: The function "RevIt" must have a prototype.
"ida.cpp", line 407: Error: The function "RevIt" must have a prototype.
"ida.cpp", line 408: Error: The operation "const int* != const unsigned char*" is illegal.
"ida.cpp", line 410: Error: The operation "const int* - const unsigned char*" is illegal.
"ida.cpp", line 412: Error: The operation "const unsigned char*const - const int*" is illegal.
9 Error(s) detected.
makefile.sun:42: recipe for target 'ida.o' failed

Performing the following does not duplicate the issue:

$ git checkout CRYPTOPP_5_6_2
$ gmake CXX=/opt/solarisstudio12.3/bin/CC ida.o
/opt/solarisstudio12.3/bin/CC -DNDEBUG -O -g0 -native -template=no%extdef -m64 -c ida.cpp

We have a test environment setup to duplicate the issue. Fix forthcoming.

[noloader]

The fix was rather easy. We needed std::random_access_iterator_tag rather than just random_access_iterator_tag. I withheld the change when we removed using namespace std because I could not test the code path. No good deed goes unpunished....

Cleared at Commit 639c9024f45506b8 (GNUmakefile) and Commit d965ca66d99df9fd (GNUmakefile and CPP files).