Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove VC++ 5.0/6.0 support #342

Closed
noloader opened this issue Dec 3, 2016 · 2 comments
Closed

Remove VC++ 5.0/6.0 support #342

noloader opened this issue Dec 3, 2016 · 2 comments

Comments

@noloader
Copy link
Collaborator

noloader commented Dec 3, 2016

Crypto++ currently supports VC++ 5.0/6.0 support from the mid 1990's. Its caused us to keep code like the following from sha.cpp:

static void X86_SHA256_HashBlocks(word32 *state, const word32 *data, size_t len
#if defined(_MSC_VER) && (_MSC_VER == 1200)
	, ...	// VC60 workaround: prevent VC 6 from inlining this function
#endif
	)

We would like to remove VC++ 5.0/6.0 support for the upcoming Crypto++ 5.7 release. Its part of a general cleanup to help with long term maintenance. Crypto++ will continue to support the early .Net compilers (VS.Net 2002 (7.0) and VS.Net 2003 (7.1)). The .Net compilers are a good choice because they are mostly conforming.

WD has no preference on the move.

@noloader
Copy link
Collaborator Author

Most of the VC++ 5.0 and 6.0 cruft was removed at Commit ba75834ae9b3846a.

We got cleaned up the remainder of the dummy parameters at Commit 86b89cd18b9df59e.

@AraHaan
Copy link

AraHaan commented Mar 2, 2017

I support this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants