New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apple Clang 6.0 and numeric_limits<word128>::max() returns 0 #364
Comments
10.9 reached end of life last year. Will cryptopp continue 10.9 support? Does cryptopp have any 10.10+ machine(s) available to do testing on? |
Yes, we support as far back as we reasonably can. OS X is a great example of why. Apple abandoned the platform, so the only way for users to stay up to date is to use up-to-date libraries. Projects like Brew, Fink and MacPorts are a great help. But they depend on projects like Botan, Crypto++ and OpenSSL maintaining libraries for them to use.
I do not. I have OS X 10.5, 10.8 and 10.9. I believe Uri tests on OS X 10.10 or 10.11. We also have gaps in testing on iPhones and iPads. I have 5 iPads, 1 iPhone and 1 iPod. All of them are older and abandoned by Apple. I think the latest OS I can test is iOS 8 or iOS 9. I have no devices for testing Apple Watch and Apple TV. I'm not sure what others have, but testing is welcomed on all of them. |
Ok. I have 10.12 to test on (also 10.10 and 10.11) but not the rest. I'm watching the repo and keep up when I can. If any OSX 10.10+ issues catch my eye then I'll see what I can do. If you happen to remember to ping me for 10.12 testing then I'll keep an eye out for that too. |
I was testing on Mac OS X 10.9, 10.10, and 10.11. Now I'm testing on 10.12, and am about to lose my only remaining 10.11 machine soon.
But I still think it is beneficial to maintain compatibility with the older OS (and to a lesser extent - older building systems).
…Sent from my iPad
On Jan 15, 2017, at 16:04, Jeffrey Walton <notifications@github.com<mailto:notifications@github.com>> wrote:
@anonimal<https://github.com/anonimal>, @mouse07410<https://github.com/mouse07410>
10.9 reached end of life last year. Will cryptopp continue 10.9 support?
Yes, we support as far back as we reasonably can. OS X is a great example of why. Apple abandoned the platform, so the only way for users to stay up to date is to use up-to-date libraries.
Projects like Brew, Fink and MacPorts are a great help. But they depend on projects like Botan, Crypto++ and OpenSSL maintaining libraries for them to use.
Does cryptopp have any 10.10+ machine(s) available to do testing on?
I do not. I have OS X 10.5, 10.8 and 10.9. I believe Uri tests on OS X 10.10 or 10.11.
We also have gaps in testing on iPhones and iPads. I have 5 iPads, 1 iPhone and 1 iPod. All of them are older and abandoned by Apple. I think the latest OS I can test is iOS 8 or iOS 9.
I have no devices for testing Apple watch and Apple TV.
I'm not sure what other users have, but testing is welcomed on all of them.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#364 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AFpi-fXI92KIzGwgLLfImGvzf-DZmDS3ks5rSonhgaJpZM4LkBQG>.
|
The issue appears to be bound to Apple Clang. Testing LLVM Clang is OK. How does the program perform on some of the later OS X's? I'm also interested in versions of Apple Clang which fail. You can compile it with
|
It looks like we need the following patch. It handles missing
|
Also see Issue 360 and http://stackoverflow.com/q/41666815
I believe this was cleared at Commit b274f062022eeb86 (Clang and GCC) and Commit 1d391c190d8c4869 (MSVC).
We added more documentation and some asserts to help folks use the functions as intended, and not operate outside the bounds. |
Apple Clang has the problem. Limit the work around to just Apple Clang.
Testing on OS X 10.9 using Apple Clang 6.0.
cryptest.sh
revealsTestRounding()
is failing one test case:Here's the debug session with
const word128 m = std::numeric_limits<word128>::max();
added for instrumentation.The tests were put in place after Issue 360.
The text was updated successfully, but these errors were encountered: