Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automation] VTAssertPaginationEquals Should Fail Entire Test #658

Open
rhsalas3 opened this issue May 13, 2022 · 0 comments
Open

[Automation] VTAssertPaginationEquals Should Fail Entire Test #658

rhsalas3 opened this issue May 13, 2022 · 0 comments

Comments

@rhsalas3
Copy link
Contributor

Description:

Based on a reported test failure in CircleCI for one of our previous PR branches, when one of the conditions w/in the VTAssertPaginationEquals func fails it does not fail the entire test. Instead the test continues and the final results report additional failures. In the example linked above, VTAssertPaginationEquals was called 4 times w/in the same test (MainScreenPaginationTests::testCanScrollPagesWithPaginationArrows) and so CircleCI erroneously reported 4 test failures.

We need to refactor our VTAssertPaginationEquals function so that it fails the test as soon as one of the assertions w/in it fails.

Acceptance Criteria:

  • VTAssertPaginationEquals fails the entire test function that calls it, when it encounters its first failed assertion
@rhsalas3 rhsalas3 added this to Ready to Select in Vocable-iOS via automation May 13, 2022
@rhsalas3 rhsalas3 moved this from Ready to Select to Backlog in Vocable-iOS May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Vocable-iOS
  
Backlog
Development

No branches or pull requests

1 participant