Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: browser finds only textual matches visible in window #799

Open
thSoft opened this issue Mar 17, 2017 · 6 comments
Open

Editor: browser finds only textual matches visible in window #799

thSoft opened this issue Mar 17, 2017 · 6 comments

Comments

@thSoft
Copy link

thSoft commented Mar 17, 2017

If I use the browser's search functionality (Ctrl/Cmd+F), only those matches are found which are visible (located in the editor section that is currently visible in the browser window).

@joshuafcole
Copy link
Contributor

This is due to CodeMirror's flywheel implementation, which enables it to render very large files without taking a severe performance hit. There is a find addon for codemirror that addresses this problem. We'd be happy to receive a PR from any interested users incorporating this, otherwise we'll return to it ourselves after we've improved the reliability of the editor.

@kayserifserif
Copy link

I'd like to take a stab at this!

@alexispurslane
Copy link

@bookwormgirl910 Are you still working on this, or can I take it up?

@kayserifserif
Copy link

@ChristopherDumas Sorry for leaving this! I haven't had time to work on it, so yes, please feel free!

@alexispurslane
Copy link

Okay! I got a few projects taken away from me on the rust compiler, so I didn't want to do that to anyone else. (:

@kayserifserif
Copy link

Aw that's very nice of you, I appreciate it! ☺️ Have fun and good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants