Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SSR version to check against major versions only closes #27972 #28114

Merged
merged 2 commits into from Nov 12, 2020

Conversation

roykho
Copy link
Member

@roykho roykho commented Oct 27, 2020

All Submissions:

Changes proposed in this Pull Request:

Change the SSR "WC tested up to" to check for major versions instead of minor.

Closes #27972

How to test the changes in this Pull Request:

  1. Use an extension such as woocommerce-bookings. Open up the main file and in the header, change the "WC tested up to" to "3.0"
  2. Go to the WC SSR page and scroll down to WooCommerce Bookings and ensure you see the message Installed version not tested with active version of WooCommerce 4.0
  3. Now edit the header "WC tested up to" to "4.0".
  4. Go back to the WC SSR page and scroll down to WooCommerce Bookings and ensure you don't see any message.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

  • Tweak - Test extension/plugins WC tested up to version against major WC versions instead of minor versions.

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@roykho roykho requested review from a team and vedanshujain and removed request for a team November 11, 2020 13:41
Copy link
Contributor

@vedanshujain vedanshujain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and testinng well

@vedanshujain
Copy link
Contributor

Looks like tests are erroring, but it seems unrelated, we can merge if they pass

@vedanshujain
Copy link
Contributor

Seems like I can't restart the build, @roykho can you please rebase the PR with master and start a Travis build again?

@roykho
Copy link
Member Author

roykho commented Nov 12, 2020

Merged master and Travis is now passing.

@roykho roykho merged commit decf180 into master Nov 12, 2020
@roykho roykho deleted the fix/issue-27972 branch November 12, 2020 14:35
@woocommercebot woocommercebot added release: add changelog Mark all PRs that have not had their changelog entries added. [auto] release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Nov 12, 2020
@roykho roykho removed the release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] label Nov 12, 2020
@jonathansadowski jonathansadowski added this to the 4.8.0 milestone Nov 12, 2020
@ObliviousHarmony ObliviousHarmony added status: changelog added release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] and removed release: add changelog Mark all PRs that have not had their changelog entries added. [auto] labels Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the compatibility notice for minor versions from SSR
5 participants