Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shipping, tax and fee lines to refund response for better information in refund REST API. #28241

Merged
merged 1 commit into from Nov 11, 2020

Conversation

vedanshujain
Copy link
Contributor

@vedanshujain vedanshujain commented Nov 11, 2020

All Submissions:

Changes proposed in this Pull Request:

This adds shipping, tax, and fee lines to refund response in API V2 and V3.

Closes #27566

How to test the changes in this Pull Request:

  1. Create an order with shipping, tax and fee lines.
  2. Refund these items.
  3. Fetch the order refunds in API V2 or V3 using /orders/{order_id}/refunds endpoint.
  4. Verify that fee_lines, shipping_lines and tax_lines are present.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enhancement - Add shipping, tax and fee lines to refund response for better information in refund REST API.

@vedanshujain vedanshujain requested review from a team and roykho and removed request for a team November 11, 2020 13:27
@vedanshujain
Copy link
Contributor Author

  • This also needs a PR to update the documentation to reflect this change, and also to clarify how to do itemized returns from the API.

Copy link
Member

@roykho roykho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well, LGTM!

@roykho roykho merged commit e0204e0 into master Nov 11, 2020
@roykho roykho deleted the fix/27566 branch November 11, 2020 16:11
@woocommercebot woocommercebot added release: add changelog Mark all PRs that have not had their changelog entries added. [auto] release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Nov 11, 2020
@roykho roykho removed the release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] label Nov 11, 2020
@jonathansadowski jonathansadowski added this to the 4.8.0 milestone Nov 12, 2020
@ObliviousHarmony ObliviousHarmony added status: changelog added and removed release: add changelog Mark all PRs that have not had their changelog entries added. [auto] labels Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shipping costs on refunds
5 participants