Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File name BEFORE the Warning & full path #119

Open
kkmuffme opened this issue Dec 9, 2018 · 3 comments · May be fixed by #361
Open

File name BEFORE the Warning & full path #119

kkmuffme opened this issue Dec 9, 2018 · 3 comments · May be fixed by #361

Comments

@kkmuffme
Copy link

kkmuffme commented Dec 9, 2018

It would be great if the i18n could include the full path to the files in Warnings & also put the file first, as this is more common among tools (eslint, php-cs-fixer,...) so easier to integrate into existing build pipelines.

Instead of this:

Warning: The string ""%s" added to cart" contains placeholders but has no "translators:" comment to clarify their meaning. (example.php:593)

we should see this:

/var/wp-content/plugins/example/example.php:593: Warning: The string ""%s" added to cart" contains placeholders but has no "translators:" comment to clarify their meaning.

Advantage:

  • no need to change lots of build pipelines, bc the format is (almost) universal
  • full path is better than only file name (especially when automating things)
@swissspidy
Copy link
Member

Great suggestion, thanks! Totally makes sense.

I wanted to improve the audit part for some time now anyway, see #39.

@swissspidy
Copy link
Member

Related: #167

@elenachavdarova
Copy link

Pull request: #361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants