Guard against boolean return value from get_latest_events() #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've observed an issue in a test environment where the `Alert_Manager::get_latest_events` method returned `false` (indicating that connectivity was lost), which is a TypeError on recent versions of PHP because `count` requires its argument to be countable. When using `declare( strict_types=1 );`, this error prevents the admin from loading when this situation occurs. This patch ensures that the admin will load even if the get_latest_events method returns false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've observed an issue in some of our test environments where the
Alert_Manager::get_latest_eventsmethod returnedfalse(indicating that connectivity was lost), which is a TypeError on recent versions of PHP becausecountrequires its argument to be countable.This patch ensures that the admin will load even if the get_latest_events method returns false.