Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove back-compat code / checks from plugin #234

Open
DannyWPWS opened this issue Nov 15, 2022 · 0 comments
Open

Remove back-compat code / checks from plugin #234

DannyWPWS opened this issue Nov 15, 2022 · 0 comments
Assignees
@DannyWPWS
Labels
enhancement New feature or request Future

Comments

@DannyWPWS
Copy link
Contributor

With WSAL 4.4.3 we have made some changes including introducing a helper class as well as the event data we pass around is no longer an Object and is an array

To avoid errors we have a number of class checks (to see if Settiings_Helper is there) as well as 'is_array' checks - lets remove these after due time
@DannyWPWS DannyWPWS added enhancement New feature or request Future labels Nov 15, 2022
@DannyWPWS DannyWPWS self-assigned this Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DannyWPWS DannyWPWS

Labels
enhancement New feature or request Future
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DannyWPWS